Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Nix Flake #459

Merged
merged 23 commits into from
Nov 29, 2024
Merged

[Feature] Nix Flake #459

merged 23 commits into from
Nov 29, 2024

Conversation

Mast3rwaf1z
Copy link
Member

@Mast3rwaf1z Mast3rwaf1z commented May 18, 2024

Added a nix flake, i have 3 things i'd like to test out with this, what is in this PR atm is just some things from #272 and some things from f-klubben/fnix#2

What i would like this flake to also do is to run the system by just calling nix run github:f-klubben/stregsystemet

The devshell should actually already be usable by running nix develop github:Mast3rwaf1z/stregsystemet

  • Implement a devshell
  • Implement some way to ensure package version
  • Create default package

Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.20%. Comparing base (294159e) to head (e7c9a00).
Report is 13 commits behind head on next.

Current head e7c9a00 differs from pull request most recent head 44b6b7f

Please upload reports for the commit 44b6b7f to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##             next     #459       +/-   ##
===========================================
+ Coverage   53.49%   81.20%   +27.70%     
===========================================
  Files          33       33               
  Lines        4621     3107     -1514     
  Branches      274      377      +103     
===========================================
+ Hits         2472     2523       +51     
+ Misses       2097      545     -1552     
+ Partials       52       39       -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mast3rwaf1z
Copy link
Member Author

Still not done at all, the default package does not want to link the python packages properly, and as such the python path only works while working with the devshell

but to be fair, you wouldn't use a flake-based default package in a server side program without the devshell if its available? hmm

@Mast3rwaf1z Mast3rwaf1z marked this pull request as ready for review June 13, 2024 14:24
requirements.txt Outdated Show resolved Hide resolved
Mast3rwaf1z and others added 2 commits September 25, 2024 16:12
rewrote the functionality of the nix flake, removed hashes from requi…
@Mast3rwaf1z
Copy link
Member Author

it should work still, without the comments :)

Copy link
Member

@krestenlaust krestenlaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for slow review! I'd mistaken it as unfinished.

LGTM! :shipit:

You can merge at will!

@Mast3rwaf1z
Copy link
Member Author

You can merge at will!

sure, let me just update the fork and test if it still works

@Mast3rwaf1z
Copy link
Member Author

i've updated the flake lock as well, so the newest nixpkgs can be used, everything still works so i'll merge

@Mast3rwaf1z Mast3rwaf1z merged commit 0da7456 into f-klubben:next Nov 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants