Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Stregsystemet #2

Closed
2 of 6 tasks
Mast3rwaf1z opened this issue Oct 18, 2023 · 2 comments · Fixed by #11
Closed
2 of 6 tasks

Package Stregsystemet #2

Mast3rwaf1z opened this issue Oct 18, 2023 · 2 comments · Fixed by #11
Assignees
Labels
enhancement New feature or request

Comments

@Mast3rwaf1z
Copy link
Member

Mast3rwaf1z commented Oct 18, 2023

Most of the work is done ish, main tasks remaining is:

  • dependencies:
    • django-select2
  • options
    • settings.py options (sed -i ''<line num> i <option> = <value>" treo/setup.py in reverse order is sufficient, do this for every config option)
    • db file (this has to be set to a writable location)
    • data file (example is the ones under stregsystem/fixtures/)

notes

  • django-select2 is not in nixpkgs, so we have to package this ourselves as well
@Mast3rwaf1z Mast3rwaf1z added the enhancement New feature or request label Oct 18, 2023
@Mast3rwaf1z Mast3rwaf1z self-assigned this Oct 18, 2023
@AshesOfEther
Copy link
Contributor

Might make more sense to do in the Stregsystem repo, so it's not unnecessarily tied to the server config.

As for django-select2, I suggest creating a pull request to Nixpkgs so others can also take advantage of it as well.

@Mast3rwaf1z
Copy link
Member Author

Might make more sense to do in the Stregsystem repo, so it's not unnecessarily tied to the server config.

i think personally i prefer keeping the configuration in one place, although keeping it in the other repo would let others add to the file with new PR's to that repo. I think i'll keep it here until we've got the full system up and running.

As for django-select2, I suggest creating a pull request to Nixpkgs so others can also take advantage of it as well.

wouldn't that mean we'd have to maintain that as well? there's methods for importing unpackaged python modules, i think that's sufficient for now

@Mast3rwaf1z Mast3rwaf1z linked a pull request Oct 26, 2023 that will close this issue
@Mast3rwaf1z Mast3rwaf1z linked a pull request Mar 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants