EZEE-3465: Refactored RepositoryConfigurationProvider #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Steveb-p
reviewed
Feb 4, 2021
eZ/Bundle/EzPublishCoreBundle/ApiLoader/RepositoryConfigurationProvider.php
Outdated
Show resolved
Hide resolved
adamwojs
requested changes
Feb 5, 2021
Comment on lines
+56
to
+63
| $aliases = array_keys($this->repositories); | ||
|
|
||
| return array_shift($aliases); |
There was a problem hiding this comment.
Could be replaced by https://www.php.net/manual/en/function.array-key-first during merge up to 3.x
eZ/Bundle/EzPublishCoreBundle/ApiLoader/RepositoryConfigurationProvider.php
Outdated
Show resolved
Hide resolved
alongosz
requested changes
Feb 5, 2021
adamwojs
approved these changes
Feb 8, 2021
eZ/Bundle/EzPublishCoreBundle/Tests/ApiLoader/RepositoryConfigurationProviderTest.php
Outdated
Show resolved
Hide resolved
barw4
force-pushed
the
ezee-3465-refactor-config-provider
branch
from
c6f4d09
to
33fbbfc
Compare
alongosz
requested changes
Feb 10, 2021
eZ/Bundle/EzPublishCoreBundle/Tests/ApiLoader/RepositoryConfigurationProviderTest.php
Outdated
Show resolved
Hide resolved
eZ/Bundle/EzPublishCoreBundle/Tests/ApiLoader/RepositoryConfigurationProviderTest.php
Outdated
Show resolved
Hide resolved
2 tasks
…er' into ezee-3465-refactor-config-provider
micszo
approved these changes
Feb 11, 2021
|
@barw4 Could you please merge up changes? |
|
Merged into: |
This was referenced Mar 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.5Minor tweaks have been made to allow pulling out the default repository and list of repositories globally.
Related
ezplatform-admin-uiPR: ezsystems/ezplatform-admin-ui#1704TODO:
$ composer fix-cs).