EZEE-3465: Tests refactor

ezsystems · Feb 9, 2021 · 33fbbfc · 33fbbfc
1 parent 26f1583
commit 33fbbfc
Showing 1 changed file with 35 additions and 19 deletions.
diff --git a/eZ/Bundle/EzPublishCoreBundle/Tests/ApiLoader/RepositoryConfigurationProviderTest.php b/eZ/Bundle/EzPublishCoreBundle/Tests/ApiLoader/RepositoryConfigurationProviderTest.php
@@ -69,19 +69,13 @@ public function testGetRepositoryConfigNotSpecifiedRepository()
     }
 
     /**
+     * @dataProvider providerForRepositories
+     *
      * @expectedException \eZ\Bundle\EzPublishCoreBundle\ApiLoader\Exception\InvalidRepositoryException
      */
-    public function testGetRepositoryConfigUndefinedRepository()
+    public function testGetRepositoryConfigUndefinedRepository(array $repositories): void
     {
         $configResolver = $this->getConfigResolverMock();
-        $repositories = [
-            'main' => [
-                'engine' => 'foo',
-            ],
-            'another' => [
-                'engine' => 'bar',
-            ],
-        ];
 
         $configResolver
             ->expects($this->once())
@@ -93,26 +87,48 @@ public function testGetRepositoryConfigUndefinedRepository()
         $provider->getRepositoryConfig();
     }
 
-    public function testGetDefaultAndCurrentRepositoryAlias(): void
+    /**
+     * @dataProvider providerForRepositories
+     */
+    public function testGetDefaultRepositoryAlias(array $repositories): void
     {
         $configResolver = $this->getConfigResolverMock();
 
-        $repositories = [
-            'first' => [
-                'engine' => 'foo',
-            ],
-            'second' => [
-                'engine' => 'bar',
-            ],
-        ];
-
         $provider = new RepositoryConfigurationProvider($configResolver, $repositories);
         $provider->getRepositoryConfig();
 
         $this->assertSame('first', $provider->getDefaultRepositoryAlias());
+    }
+
+    /**
+     * @dataProvider providerForRepositories
+     */
+    public function testGetCurrentRepositoryAlias(array $repositories): void
+    {
+        $configResolver = $this->getConfigResolverMock();
+
+        $provider = new RepositoryConfigurationProvider($configResolver, $repositories);
+        $provider->getRepositoryConfig();
+
         $this->assertSame('first', $provider->getCurrentRepositoryAlias());
     }
 
+    public function providerForRepositories(): array
+    {
+        return [
+            [
+                [
+                    'first' => [
+                        'engine' => 'foo',
+                    ],
+                    'second' => [
+                        'engine' => 'bar',
+                    ],
+                ],
+            ],
+        ];
+    }
+
     /**
      * @return \PHPUnit\Framework\MockObject\MockObject|\eZ\Publish\Core\MVC\ConfigResolverInterface
      */