Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZEE-3453: Added SQL update scripts #646

Merged
merged 3 commits into from
Jan 27, 2021
Merged

EZEE-3453: Added SQL update scripts #646

merged 3 commits into from
Jan 27, 2021

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk requested review from alongosz and a team January 22, 2021 10:30
tomaszszopinski
tomaszszopinski approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa Commerce 3.2.4-dev with diff & patch.

alongosz
alongosz requested changes Jan 25, 2021
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if someone already had changed e-mails of system users? This upgrade script should be concerned only with a result of clean installation, thus WHERE email = '[email protected]'; Otherwise this would overwrite custom user data.

@lserwatka lserwatka merged commit 4deb6dd into ezsystems:3.2 Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ciastektk @alongosz @tomaszszopinski @lserwatka