Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZEE-3453: Fixed admin user draft create during frontend login #162

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Jan 20, 2021

Question Answer
JIRA issue https://issues.ibexa.co/browse/EZEE-3453
Type bug
Target eZ Platform version v3.2
BC breaks no
Doc needed no

Exception Email '[email protected]' is used by another user. You must enter a unique email. is thrown during frontend login by admin user. Commerce provides user update by CustomerProfileData in EzErpCustomerProfileDataService::storeCustomerProfileDataInEz during frontend login but updated content cannot be published because admin user has the same email address as a anonymous user and content draft is created.
By default email field is set as unique but clean data provides same email address for admin and anonymous users (52e9563#diff-ac44ef55a5bfbb578a08eca35f5a9ded0d2db5f6247e9fdae12cc333c645d342).

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@ciastektk ciastektk requested review from alongosz and a team January 20, 2021 12:47
@@ -824,8 +824,8 @@ ezurlalias_ml_incr:
- { id: 41 }
ezurlwildcard: { }
ezuser:
- { contentobject_id: 10, email: [email protected], login: anonymous, password_hash: $2y$10$35gOSQs6JK4u4whyERaeUuVeQBi2TUBIZIfP7HEj7sfz.MxvTuOeC, password_hash_type: 7 }
- { contentobject_id: 14, email: [email protected], login: admin, password_hash: $2y$10$FDn9NPwzhq85cLLxfD5Wu.L3SL3Z/LNCvhkltJUV0wcJj7ciJg2oy, password_hash_type: 7 }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this change affects integration tests in migration bundle. Please ping me if/when this change goes through.

@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
60.6% 60.6% Duplication

Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa Commerce 3.2.4-dev with diff & patch.

@lserwatka lserwatka merged commit 01e30cd into ezsystems:1.2 Jan 27, 2021
@tomaszszopinski
Copy link

Could you merge it up?

@ciastektk ciastektk deleted the ezee-3453-fixed-admin-user-draft-create-during-frontend-login branch January 27, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants