Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32128: Variations hrefs no longer generated for removed image asset relation #59

Merged
merged 1 commit into from
Nov 12, 2020
Merged

EZP-32128: Variations hrefs no longer generated for removed image asset relation #59

merged 1 commit into from
Nov 12, 2020

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Nov 4, 2020 •
edited
Loading

Question Answer
JIRA issue EZP-32128
Type bug
Target version v3.2
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@ViniTou ViniTou mentioned this pull request Nov 4, 2020
Merged
6 tasks
tomaszszopinski
tomaszszopinski approved these changes Nov 12, 2020
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaExp 3.2.1-dev with patch.

@adamwojs adamwojs merged commit 5f55165 into 1.2 Nov 12, 2020
@adamwojs adamwojs deleted the ezp-32128-removed-image-asset branch November 12, 2020 08:29
@adamwojs
Copy link
Member

Could you please merge up changes @ViniTou?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@alongosz alongosz Awaiting requested review from alongosz

@kaff kaff Awaiting requested review from kaff

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

@webhdx webhdx Awaiting requested review from webhdx

Assignees
No one assigned
Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ViniTou @adamwojs @tomaszszopinski