Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-32128: Thumbnails are no longer generated for removed image asset relation #132

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Nov 4, 2020

Question Answer
JIRA issue EZP-32128
Type bug
Target eZ Platform version v3.1
BC breaks no
Doc needed no

This not fix exactly issue described in jira ticket, but as steps to reproduce are that same and int affects similar scope I solved both of issues at that same time. As this refers to failure with obtaining content thumbnail it also affects 3.1 (in opposition to ezsystems/ezplatform-rest#59)

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform-ee 3.1 with diff.

@adamwojs adamwojs merged commit cbf3882 into 1.1 Nov 12, 2020
@adamwojs adamwojs deleted the EZP-32128-removed-image-asset branch November 12, 2020 07:16
@adamwojs
Copy link
Member

Could you please merge up changes @ViniTou?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants