Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-3067: Fixed JS validation for float and integer fieldtypes #2056

Merged
merged 1 commit into from
Jul 6, 2022
Merged

IBX-3067: Fixed JS validation for float and integer fieldtypes #2056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bundle/Resources/public/js/scripts/fieldType/ezfloat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
const isFloat = Number.isInteger(value) || value % 1 !== 0;
const isLess = value < parseFloat(event.target.getAttribute('min'));
const isGreater = value > parseFloat(event.target.getAttribute('max'));
const isError = (isEmpty && isRequired) || !isFloat || isLess || isGreater;
const isError = (isEmpty && isRequired) || (!isEmpty && (!isFloat || isLess || isGreater));
const label = event.target.closest(SELECTOR_FIELD).querySelector('.ez-field-edit__label').innerHTML;
const result = { isError };

Expand Down
2 changes: 1 addition & 1 deletion src/bundle/Resources/public/js/scripts/fieldType/ezinteger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
const isInteger = Number.isInteger(value);
const isLess = value < parseInt(event.target.getAttribute('min'), 10);
const isGreater = value > parseInt(event.target.getAttribute('max'), 10);
const isError = (isEmpty && isRequired) || !isInteger || isLess || isGreater;
const isError = (isEmpty && isRequired) || (!isEmpty && (!isInteger || isLess || isGreater));
const label = event.target.closest(SELECTOR_FIELD).querySelector('.ez-field-edit__label').innerHTML;
const result = { isError };

Expand Down