Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-3067: Fixed JS validation for float and integer fieldtypes #2056

Merged
merged 1 commit into from
Jul 6, 2022
Merged

IBX-3067: Fixed JS validation for float and integer fieldtypes #2056

merged 1 commit into from
Jul 6, 2022

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Jul 4, 2022

Question Answer
Tickets IBX-3067
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 requested a review from a team July 4, 2022 13:08
@barw4 barw4 self-assigned this Jul 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mnocon
mnocon approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the behaviour with interger and float fieldtypes, it's correct now.

QA Approved!

@dew326 dew326 merged commit 8a41e6e into 2.3 Jul 6, 2022
@dew326 dew326 deleted the ibx-3067-fix-int-and-float-js-validation branch July 6, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@mnocon mnocon mnocon approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@dew326 dew326

@barw4 barw4

Labels
Bug QA approved Ready for MERGE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barw4 @GrabowskiM @mnocon @dew326