Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3867 docs: update the example in the readme so that it uses const instead of var #3868

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

mwanago
Copy link
Contributor

@mwanago mwanago commented Jan 30, 2019

Closes #3867

@wesleytodd
Copy link
Member

I just want to say that I am lukewarm on these kind of updates. I feel like it is fine and well to follow common developer practices with the examples, but I don't see a lot of value in changing perfectly functional examples.

This is coming from someone who does define my imports as consts, so I am not being grumpy about change. Just saying that making change just to do this kind of stuff is more noise than signal.

@cujarrett
Copy link

Looks good 😃

@dougwilson
Copy link
Contributor

@wesleytodd I don't really care for these either, but since it does work on our target Node.js versions and perhaps will stop this particular PR in the future, I may as well merge it in.

@dougwilson dougwilson merged commit 6eda52a into expressjs:4.17 Apr 16, 2019
dougwilson pushed a commit that referenced this pull request Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants