Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the example in the readme so that it uses const instead of var #3867

Closed
mwanago opened this issue Jan 30, 2019 · 7 comments
Closed

Update the example in the readme so that it uses const instead of var #3867

mwanago opened this issue Jan 30, 2019 · 7 comments
Labels
docs

Comments

@mwanago
Copy link
Contributor

mwanago commented Jan 30, 2019

No description provided.

@dougwilson
Copy link
Contributor

The readme supports the same Node.js versions the module supports.

@dougwilson
Copy link
Contributor

Well, this particular placement of const I think is supported in Node.js 0.10. Someone will need to validate.

@dougwilson dougwilson reopened this Jan 30, 2019
@mwanago
Copy link
Contributor Author

mwanago commented Jan 30, 2019

@dougwilson I will investigate and open a PR if it turns out to work fine

@mwanago
Copy link
Contributor Author

mwanago commented Jan 30, 2019 •
edited
Loading

@dougwilson Turns out it works well. I tested it with this version:
https://nodejs.org/dist/v0.10.0/

@mwanago mwanago mentioned this issue Jan 30, 2019
Merged
@mwanago
Copy link
Contributor Author

mwanago commented Mar 8, 2019

@dougwilson Are there any plans on merging this?

@dougwilson
Copy link
Contributor

So this is an issue, which doesn't have anything to merge. Can you link me to the pull request you're asking about?

@mwanago
Copy link
Contributor Author

mwanago commented Mar 11, 2019

@dougwilson For me the PR displays as connected on the page of the issue.
#3868

Have an awesome day.

dougwilson pushed a commit to mwanago/express that referenced this issue Apr 16, 2019
@mwanago @dougwilson
docs: use const in readme example
6eda52a 
fixes expressjs#3867
closes expressjs#3868
dougwilson pushed a commit that referenced this issue Apr 17, 2019
@mwanago @dougwilson
docs: use const in readme example
c5e9d6a 
fixes #3867
closes #3868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dougwilson @mwanago