[1/1][docs] Add FCM V1 instructions to Google Service Account Key docs #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherwalter
force-pushed
the
chriswalter/eng-11172-fcmv1-specify-creds-in-eas-cli-2-gsak-docs
branch
from
5336485 to
63b13ca
Compare
|
@quinlanj @amandeepmittal this is a pretty rough draft but I was hoping to get your feedback on the copy and layout changes. I'll update with the correct image URLs before landing. |
quinlanj
requested changes
Feb 7, 2024
christopherwalter
force-pushed
the
chriswalter/eng-11172-fcmv1-specify-creds-in-eas-cli-2-gsak-docs
branch
2 times, most recently
from
648ddf9 to
e0d3854
Compare
# Why We need to amend these docs to support using a Google Service Account Key for sending Android notifications via FCM V1. These docs are linked in the CLI when users are configuring Google Service Account Keys for submissions and notifications. (See @quinlanj's comment on this PR in eas-cli: expo/eas-cli#2197 (comment)). # How 1. Update the top-level intro with an explanation of the two use cases for uploading a Google Service Account Key to EAS. 2. Move existing instructions for `eas submit` into a new subsection 3. Add a subsection for instructions for uploading GSAK for FCM V1 # Test Plan Get feedback on copy, check that preview markdown looks good
christopherwalter
force-pushed
the
chriswalter/eng-11172-fcmv1-specify-creds-in-eas-cli-2-gsak-docs
branch
from
e0d3854 to
6302597
Compare
amandeepmittal
approved these changes
Feb 9, 2024
Co-authored-by: Aman Mittal <[email protected]>
christopherwalter
deleted the
chriswalter/eng-11172-fcmv1-specify-creds-in-eas-cli-2-gsak-docs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We need to amend these docs to support using a Google Service Account Key for sending Android notifications via FCM V1. These docs are linked in the CLI when users are configuring Google Service Account Keys for submissions and notifications. (See @quinlanj's comment on this PR in eas-cli: expo/eas-cli#2197 (comment)).
How
eas submitinto a new subsectionTest Plan
Get feedback on copy, check that preview markdown looks good