[fcmv1] Manage FCM V1 Google Service Account Key in CLI

[christopherwalter]

Why

NOTE: DO NOT LAND THIS UNTIL GRAPHQL CHANGES LAND IN WWW

We're adding support for FCM V1 credentials, as Google is shutting down the FCM Legacy API for sending Android notifications in June.

How

Add new prompts and refactor existing prompts to match this schematic:

Test Plan

Verified all functionality e2e:

[linear]

ENG-11172 [fcmv1] Specify creds in EAS CLI

[github-actions]

Size Change: +3.35 kB (0%)

Total Size: 51.3 MB

Filename	Size	Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz	51.3 MB	+3.35 kB (0%)

_{compressed-size-action}

[quinlanj]

I ran this version of eas-cli against your changes in www and the UX looks good. Thank you! Requesting changes for deduping classes 🙏

edit: When you are ready with the amended changes, please re-request review!

[quinlanj]

Assigning actions

I agree with you here -- these actions makes sense to keep the submission and fcmv1 separate.
AssignGoogleServiceAccountKey - Let's rename this class to AssignGoogleServiceAccountKeyForSubmissions:

eas-cli/packages/eas-cli/src/credentials/android/actions/AssignGoogleServiceAccountKey.ts

Line 9 in eb9152a

export class AssignGoogleServiceAccountKey {

Create GSAK actions

There will be 3 'contexts' for creation:

1. generic Upload a GSAK option
2. setting up a submission GSAK (creates and assigns for submissions)
3. setting up an FCM v1 GSAK (creates and assigns for FCMV1)

IMO the most important bit of logging here is this fyi bit. For the generic case, we'd want the fyi to link a generic page which lists the pages for submissions and fcmv1. For the specialized FCM and Submission cases, we'd want the fyi to lead to their respective instructions for the permissions the user needs to assign to that GSAK.

My vote is to refactor this one into a single class since there are 3 logging contexts, but the underlying logic is the same

SetUp GSAK actions

I'm ok with what you have here 👍

[szdziedzic]

It looks reasonable to me 👍

Thanks for sharing the video from e2e testing the change and thanks for taking care of it 🙌

[christopherwalter]

IMO the most important bit of logging here is this fyi bit. For the generic case, we'd want the fyi to link a generic page which lists the pages for submissions and fcmv1. For the specialized FCM and Submission cases, we'd want the fyi to lead to their respective instructions for the permissions the user needs to assign to that GSAK.

@quinlanj I removed CreateGoogleServiceAccountKeyForFcmV1 and updated the logging in CreateGoogleServiceAccountKey to include language about both the submission use case as well as the notifications use case. I also have this PR up to update the FYI docs for the two use cases.

Let me know what you think.

[christopherwalter]

/changelog-entry new-feature Support configuring a Google Service Account Key via eas credentials, for sending Android Notifications via FCM V1

[christopherwalter]

/changelog-entry new-feature Support configuring a Google Service Account Key via eas credentials, for sending Android Notifications via FCM V1

[github-actions]

✅ Thank you for adding the changelog entry!

[codecov]

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (0b71812) 54.16% compared to head (66452b9) 54.08%.

Files	Patch %	Lines
...id/actions/SetUpGoogleServiceAccountKeyForFcmV1.ts	24.25%	22 Missing and 3 partials ⚠️
...s/eas-cli/src/credentials/manager/ManageAndroid.ts	16.67%	19 Missing and 1 partial ⚠️
...d/actions/AssignGoogleServiceAccountKeyForFcmV1.ts	25.00%	6 Missing ⚠️
...graphql/mutations/AndroidAppCredentialsMutation.ts	0.00%	4 Missing ⚠️
.../src/credentials/android/utils/printCredentials.ts	75.00%	3 Missing ⚠️
...s-cli/src/credentials/android/api/GraphqlClient.ts	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2197      +/-   ##
==========================================
- Coverage   54.16%   54.08%   -0.08%     
==========================================
  Files         516      518       +2     
  Lines       18814    18894      +80     
  Branches     3969     3984      +15     
==========================================
+ Hits        10188    10216      +28     
- Misses       7934     7981      +47     
- Partials      692      697       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.