Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Prevent eas-cli dependencies check from running repeatedly #2781

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Dec 19, 2024

Why

There seem to be several cases where we call the function that's been modified in this PR repeatedly causing the following messages to be printed several times:

Found eas-cli in your project dependencies.
It's recommended to use the "cli.version" field in eas.json to enforce the eas-cli version for your project.
Learn more: https://github.com/expo/eas-cli#enforcing-eas-cli-version-for-your-project

How

Adds a flag to only run this function once.

Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

@kitten kitten force-pushed the @kitten/fix/prevent-repeated-logs branch from bef94cb to 93982ed Compare December 19, 2024 03:14
Copy link

github-actions bot commented Dec 19, 2024

Size Change: -3.31 kB (-0.01%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -3.31 kB (-0.01%)

compressed-size-action

Copy link

✅ Thank you for adding the changelog entry!

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.51%. Comparing base (4bb550e) to head (34d1353).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...tUtils/findProjectDirAndVerifyProjectSetupAsync.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2781      +/-   ##
==========================================
- Coverage   52.52%   52.51%   -0.00%     
==========================================
  Files         583      583              
  Lines       22576    22579       +3     
  Branches     4450     4451       +1     
==========================================
+ Hits        11855    11856       +1     
- Misses      10686    10688       +2     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kitten kitten merged commit d126ee9 into main Dec 19, 2024
10 checks passed
@kitten kitten deleted the @kitten/fix/prevent-repeated-logs branch December 19, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants