Skip to content

Commit

Permalink
[eas-cli] Prevent eas-cli dependencies check from running repeatedly (
Browse files Browse the repository at this point in the history
#2781)

* Only check for dependencies once

* Add CHANGELOG entry

* Apply lints
  • Loading branch information
kitten authored Dec 19, 2024
1 parent 4bb550e commit d126ee9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ This is the log of notable changes to EAS CLI and related packages.
### 🐛 Bug fixes

- Show `eas deploy` upload error messages. ([#2771](https://github.com/expo/eas-cli/pull/2771) by [@kadikraman](https://github.com/kadikraman))
- Prevent EAS CLI dependencies check from running repeatedly. ([#2781](https://github.com/expo/eas-cli/pull/2781) by [@kitten](https://github.com/kitten))

### 🧹 Chores

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ export async function findProjectRootAsync({
}
}

let ranEnsureEasCliIsNotInDependencies = false;

/**
* Determine the project root directory and ensure some constraints about the project setup
* like CLI version and dependencies.
Expand All @@ -113,6 +115,9 @@ export async function findProjectRootAsync({
export async function findProjectDirAndVerifyProjectSetupAsync(): Promise<string> {
const projectDir = await findProjectRootAsync();
await applyCliConfigAsync(projectDir);
await ensureEasCliIsNotInDependenciesAsync(projectDir);
if (!ranEnsureEasCliIsNotInDependencies) {
ranEnsureEasCliIsNotInDependencies = true;
await ensureEasCliIsNotInDependenciesAsync(projectDir);
}
return projectDir;
}

0 comments on commit d126ee9

Please sign in to comment.