[chore] Enable more eslint rules to match other expo repos

[wschurman]

Why

This enables the "return await" lint rule, which is useful for catching bugs that surround an unawaited promise with a try/catch.

How

Enable the rule, manually audit and fix the lint issues.

Test Plan

yarn lint

[wschurman]

• [chore] Enable remaining lint rules and fix lots of bugs #2510
• [chore] Apply more lint #2509
• [chore] Enable more eslint rules to match other expo repos #2508 👈
• [chore] Enable more lint rules to align with other expo codebases #2507
• [chore] Add typescript linting to packages #2505 : 1 other dependent PR (#2506 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wschurman and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 47.45763% with 31 lines in your changes missing coverage. Please review.

Project coverage is 52.95%. Comparing base (9597ea2) to head (e3e1b9e).
Report is 1 commits behind head on main.

Files	Patch %	Lines
packages/eas-cli/src/submit/ArchiveSource.ts	66.67%	5 Missing ⚠️
...ntials/ios/actions/DistributionCertificateUtils.ts	0.00%	4 Missing ⚠️
...s/eas-cli/src/credentials/ios/appstore/keychain.ts	0.00%	4 Missing ⚠️
...as-cli/src/credentials/ios/actions/PushKeyUtils.ts	0.00%	2 Missing ⚠️
...src/credentials/ios/appstore/resolveCredentials.ts	0.00%	2 Missing ⚠️
packages/eas-cli/src/utils/download.ts	0.00%	2 Missing ⚠️
packages/eas-cli/src/build/ios/build.ts	0.00%	1 Missing ⚠️
...ntials/ios/actions/SetUpDistributionCertificate.ts	0.00%	1 Missing ⚠️
...s-cli/src/credentials/ios/appstore/authenticate.ts	0.00%	1 Missing ⚠️
...s/eas-cli/src/credentials/ios/appstore/bundleId.ts	0.00%	1 Missing ⚠️
... and 8 more

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2508   +/-   ##
=======================================
  Coverage   52.95%   52.95%           
=======================================
  Files         544      544           
  Lines       20061    20061           
  Branches     4098     4098           
=======================================
  Hits        10621    10621           
  Misses       8626     8626           
  Partials      814      814           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Size Change: -1.81 kB (0%)

Total Size: 51.1 MB

Filename	Size	Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz	51.1 MB	-1.81 kB (0%)

_{compressed-size-action}

[wschurman]

Merge activity

• Aug 21, 12:11 PM EDT: @wschurman started a stack merge that includes this pull request via Graphite.
• Aug 21, 12:17 PM EDT: Graphite rebased this pull request as part of a merge.
• Aug 21, 12:18 PM EDT: @wschurman merged this pull request with Graphite.

[github-actions]

❌ It looks like a changelog entry is missing for this PR. You have two options: you can add it manually, or you can use the changelog bot to do it for you.
🤖 To use the bot, simply comment on this PR with the command /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message].
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.