[chore] Enable more lint rules to align with other expo codebases

[wschurman]

Why

This PR enables lint rules for things that are:

• good code correctness features (readonly rules)
• remove redundancy (redundant type casts)

How

Enable rules, yarn lint --fix

Test Plan

yarn lint

[wschurman]

• [chore] Enable remaining lint rules and fix lots of bugs #2510
• [chore] Apply more lint #2509
• [chore] Enable more eslint rules to match other expo repos #2508
• [chore] Enable more lint rules to align with other expo codebases #2507 👈
• [chore] Add typescript linting to packages #2505 : 1 other dependent PR (#2506 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wschurman and the rest of your teammates on Graphite

[github-actions]

Size Change: +2.54 kB (0%)

Total Size: 51.1 MB

Filename	Size	Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz	51.1 MB	+2.54 kB (0%)

_{compressed-size-action}

[codecov]

Codecov Report

Attention: Patch coverage is 65.09434% with 37 lines in your changes missing coverage. Please review.

Project coverage is 52.95%. Comparing base (5976dc7) to head (d4e737c).
Report is 1 commits behind head on main.

Files	Patch %	Lines
...ctions/SetUpBuildCredentialsFromCredentialsJson.ts	0.00%	3 Missing ⚠️
...c/credentials/ios/actions/UpdateCredentialsJson.ts	0.00%	3 Missing ⚠️
...kages/eas-cli/src/rollout/actions/ManageRollout.ts	0.00%	3 Missing ⚠️
.../credentials/android/AndroidCredentialsProvider.ts	0.00%	2 Missing ⚠️
...als/manager/CheckBuildProfileFlagAgainstEasJson.ts	0.00%	2 Missing ⚠️
...kages/eas-cli/src/rollout/actions/CreateRollout.ts	0.00%	1 Missing and 1 partial ⚠️
packages/eas-cli/src/rollout/actions/EndRollout.ts	0.00%	2 Missing ⚠️
packages/eas-cli/src/build/build.ts	0.00%	1 Missing ⚠️
packages/eas-cli/src/commands/build/cancel.ts	0.00%	1 Missing ⚠️
packages/eas-cli/src/commands/build/delete.ts	0.00%	1 Missing ⚠️
... and 17 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2507      +/-   ##
==========================================
- Coverage   52.95%   52.95%   -0.00%     
==========================================
  Files         544      544              
  Lines       20060    20061       +1     
  Branches     4098     4098              
==========================================
  Hits        10621    10621              
- Misses       8625     8626       +1     
  Partials      814      814              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[szdziedzic]

Thanks!

[wschurman]

Merge activity

• Aug 21, 12:11 PM EDT: @wschurman started a stack merge that includes this pull request via Graphite.
• Aug 21, 12:13 PM EDT: Graphite rebased this pull request as part of a merge.
• Aug 21, 12:14 PM EDT: @wschurman merged this pull request with Graphite.

[github-actions]

❌ It looks like a changelog entry is missing for this PR. You have two options: you can add it manually, or you can use the changelog bot to do it for you.
🤖 To use the bot, simply comment on this PR with the command /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message].
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.