Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] resolve correct submit profile configuration for eas build --auto-submit-with-profile #2425

Conversation

szdziedzic
Copy link
Member

Why

In #2101 we added a logic to refresh the submit profile with the new submit profile with submit profile name === build profile name (if it exists) unless the submissionCtx.specifiedProfile value is set.

However, we didn't set the submissionCtx.specifiedProfile for submissions triggered via eas build --auto-submit and this caused us to always refresh the submit profile with the submit profile with the name of the build profile.

if (archiveProfile && !this.ctx.specifiedProfile) {
this.ctx = await refreshContextSubmitProfileAsync(this.ctx, archiveProfile);
}

It's also the root cause of https://exponent-internal.slack.com/archives/C02123T524U/p1718015524335999 issue

How

Set submissionCtx.specifiedProfile for submission triggered by the eas build --auto-submit-with-profile command.

Test Plan

test manually

@szdziedzic szdziedzic marked this pull request as ready for review June 12, 2024 14:04
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (3817e2d) to head (55f0567).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2425   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         530      530           
  Lines       19509    19509           
  Branches     3968     3968           
=======================================
  Hits        10427    10427           
  Misses       8330     8330           
  Partials      752      752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 12, 2024

Size Change: +1.99 kB (0%)

Total Size: 52 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52 MB +1.99 kB (0%)

compressed-size-action

Copy link

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit 5f800b5 into main Jun 12, 2024
9 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/fix-bug-with-invalid-submit-profile-being-used-when-running-auto-submit-with-profile branch June 12, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants