[eas-cli] [ENG-8973] Use selected builds profile name if not specified #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When user calls `eas submit` command without specified profile name, the command used to default to `production` profile. If the user then selects one of their builds from EAS which was built with another build profile, then using the `production` submit profile may be confusing. Now, after selecting the build from EAS, command checks if a corresponding submit profile with the same name as seleted build's build profile exists, and if so uses that submit profile See: https://linear.app/expo/issue/ENG-8973/eas-submit-doesnt-use-asc-configuration-from-selected-build-profile
Added tests for IosSubmitCommand and AndroidSubmitCommand checking what params are passed to SubmissionMutation when user selects build from EAS and corresponding submit profile exists/does not exist See: https://linear.app/expo/issue/ENG-8973/eas-submit-doesnt-use-asc-configuration-from-selected-build-profile
Added tests for new `refreshContextSubmitProfileAsync` function See: https://linear.app/expo/issue/ENG-8973/eas-submit-doesnt-use-asc-configuration-from-selected-build-profile
radoslawkrzemien
requested review from
szdziedzic and
khamilowicz
as code owners
ENG-8973 eas submit doesn't use ASC configuration from selected build profile
If you don't specify a profile when running However, it ignores it. This is counterintuitive. My suggestion would be that if a build is picked from the website, to use that profile for the ASC configuration. |
…-8973-use-selected-builds-profile-name-if-not-specified
|
/changelog-entry new-feature Use corresponding submit profile when selecting build from EAS |
|
Size Change: +5.23 kB (0%) Total Size: 42.6 MB
|
Codecov Report
@@ Coverage Diff @@
## main #2101 +/- ##
==========================================
+ Coverage 54.14% 54.20% +0.06%
==========================================
Files 509 509
Lines 18624 18652 +28
Branches 3922 3933 +11
==========================================
+ Hits 10083 10108 +25
- Misses 7854 7857 +3
Partials 687 687
|
Just noticed that if the user does specify the profile and then selects the build from EAS, that specified profile would then be overwritten by the profile corresponding with the one from selected build. This shouldn't be the case and this commit fixes that See: https://linear.app/expo/issue/ENG-8973/eas-submit-doesnt-use-asc-configuration-from-selected-build-profile
Added tests for cases when matching submit profile exists for selected build but the user explicitly specifies another profile when calling the command See: https://linear.app/expo/issue/ENG-8973/eas-submit-doesnt-use-asc-configuration-from-selected-build-profile
Function should not be called when user specifies the profile name so the message is adjusted to not include such a case See: https://linear.app/expo/issue/ENG-8973/eas-submit-doesnt-use-asc-configuration-from-selected-build-profile
|
✅ Thank you for adding the changelog entry! |
radoslawkrzemien
deleted the
@radoslawkrzemien/ENG-8973-use-selected-builds-profile-name-if-not-specified
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://linear.app/expo/issue/ENG-8973/eas-submit-doesnt-use-asc-configuration-from-selected-build-profile
How
Moved the archive selection before any submit options are determined, and if the archive is selected from EAS then the profile in the submission context is refreshed to use the submit profile with same name as the name of the build profile in the archive (if exists)
Test Plan
Added automated tests and checked parts of the process manually
When corresponding build profile does not exist
