[eas-cli] don't allow to specify custom global version of deprecated expo-cli

CHANGELOG.md

@@ -18,6 +18,7 @@ This is the log of notable changes to EAS CLI and related packages.
 
 - Remove more classic updates code. ([#2357](https://github.com/expo/eas-cli/pull/2357) by [@wschurman](https://github.com/wschurman))
 - Upgrade [`eas-build`](https://github.com/expo/eas-build) dependencies. ([#2360](https://github.com/expo/eas-cli/pull/2360) by [@expo-bot](https://github.com/expo-bot))
+- Don't pass custom global `"expoCli"` version set in `eas.json` to EAS Build process and warn users when setting it. ([#2361](https://github.com/expo/eas-cli/pull/2361) by [@szdziedzic](https://github.com/szdziedzic))
 
 ## [8.0.0](https://github.com/expo/eas-cli/releases/tag/v8.0.0) - 2024-05-01
 

packages/eas-cli/package.json

@@ -13,7 +13,7 @@
     "@expo/config": "8.5.4",
     "@expo/config-plugins": "7.8.4",
     "@expo/config-types": "50.0.0",
-    "@expo/eas-build-job": "1.0.106",
+    "@expo/eas-build-job": "1.0.107",
     "@expo/eas-json": "8.0.0",
     "@expo/json-file": "8.2.37",
     "@expo/logger": "1.0.57",
@@ -28,7 +28,7 @@
     "@expo/results": "1.0.0",
     "@expo/rudder-sdk-node": "1.1.1",
     "@expo/spawn-async": "1.7.0",
-    "@expo/steps": "1.0.106",
+    "@expo/steps": "1.0.107",
     "@expo/timeago.js": "1.0.0",
     "@oclif/core": "^1.26.2",
     "@oclif/plugin-autocomplete": "^2.3.10",

packages/eas-cli/src/build/android/prepareJob.ts

@@ -68,7 +68,6 @@ export async function prepareJobAsync(
       bun: buildProfile.bun,
       yarn: buildProfile.yarn,
       ndk: buildProfile.ndk,
-      expoCli: buildProfile.expoCli,
       env: buildProfile.env,
     },
     cache: {

packages/eas-cli/src/build/ios/prepareJob.ts

@@ -62,7 +62,6 @@ export async function prepareJobAsync(
       bundler: buildProfile.bundler,
       cocoapods: buildProfile.cocoapods,
       fastlane: buildProfile.fastlane,
-      expoCli: buildProfile.expoCli,
       env: buildProfile.env,
     },
     cache: {

packages/eas-json/package.json

@@ -6,7 +6,7 @@
   "bugs": "https://github.com/expo/eas-cli/issues",
   "dependencies": {
     "@babel/code-frame": "7.23.5",
-    "@expo/eas-build-job": "1.0.106",
+    "@expo/eas-build-job": "1.0.107",
     "chalk": "4.1.2",
     "env-string": "1.0.1",
     "fs-extra": "11.2.0",

packages/eas-json/schema/eas.schema.json

@@ -156,11 +156,6 @@
           "description": "The version of Bun to use for the build. See: https://bun.sh/",
           "markdownDescription": "The exact version of [Bun](https://bun.sh/) to use for the build."
         },
-        "expoCli": {
-          "type": "string",
-          "description": "The version of `expo-cli` used to `prebuild` your app.",
-          "markdownDescription": "Version of [expo-cli](https://www.npmjs.com/package/expo-cli) used to [prebuild](https://docs.expo.dev/workflow/expo-cli/#expo-prebuild) your app. It does not have any effect on bare projects."
-        },
         "env": {
           "type": "object",
           "description": "Environment variables that should be set during the build process.\n\nShould only be used for values that you would commit to your git repository, i.e. not passwords or secrets.",

packages/eas-json/src/build/types.ts

@@ -38,6 +38,9 @@ export interface CommonBuildProfile {
   pnpm?: string;
   bun?: string;
   yarn?: string;
+  /**
+   * @deprecated
+   */
   expoCli?: string;
 
   // credentials

packages/eas-json/src/utils.ts

@@ -51,6 +51,16 @@ export class EasJsonUtils {
       });
     }
 
+    if (buildProfile.expoCli) {
+      warnings.push({
+        message: [
+          `The "build.${profileName}.expoCli" field in eas.json is deprecated and will be removed in the future.`,
+          `Global Expo CLI is deprecated. Since Expo SDK 46 local Expo CLI shipped with "expo" package is used. Remove this field from eas.json.`,
+          `Using this field has no effect on EAS Build process.`,
+        ],
+      });
+    }
+
     warnings.push(...EasJsonUtils.getCustomPathsDeprecationWarnings(rawEasJson, profileName));
 
     return warnings;