Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] don't allow to specify custom global version of deprecated expo-cli #2361

Conversation

szdziedzic
Copy link
Member

Why

Global expo-cli has been deprecated for a very long time now

How

don't allow to specify custom global version of deprecated expo-cli

Test Plan

tests

@szdziedzic
Copy link
Member Author

/changelog-entry breaking-change Don't allow to specify a custom version of deprecated global expo-cli in eas.json

Copy link

github-actions bot commented May 7, 2024

Size Change: -842 B (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB -842 B (0%)

compressed-size-action

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.83%. Comparing base (de8956c) to head (f710c3f).

Files Patch % Lines
packages/eas-json/src/utils.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2361      +/-   ##
==========================================
- Coverage   53.83%   53.83%   -0.00%     
==========================================
  Files         525      525              
  Lines       19275    19277       +2     
  Branches     4074     4075       +1     
==========================================
+ Hits        10375    10376       +1     
- Misses       8180     8181       +1     
  Partials      720      720              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we warn people if they are using this field, rather than failing validation and preventing build? could be annoying if anyone has this just left over in their eas.json and then their build pipeline starts failing with latest eas-cli

@szdziedzic
Copy link
Member Author

can we warn people if they are using this field, rather than failing validation and preventing build? could be annoying if anyone has this just left over in their eas.json and then their build pipeline starts failing with latest eas-cli

sure

@szdziedzic szdziedzic force-pushed the @szdziedzic/dont-allow-to-specify-custom-global-expo-cli-version branch from e046460 to 50801dc Compare May 8, 2024 09:01
Copy link

github-actions bot commented May 8, 2024

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit f9ef83b into main May 8, 2024
9 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/dont-allow-to-specify-custom-global-expo-cli-version branch May 8, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants