-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] don't allow to specify custom global version of deprecated expo-cli
#2361
[eas-cli] don't allow to specify custom global version of deprecated expo-cli
#2361
Conversation
/changelog-entry breaking-change Don't allow to specify a custom version of deprecated global |
Size Change: -842 B (0%) Total Size: 51.3 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2361 +/- ##
==========================================
- Coverage 53.83% 53.83% -0.00%
==========================================
Files 525 525
Lines 19275 19277 +2
Branches 4074 4075 +1
==========================================
+ Hits 10375 10376 +1
- Misses 8180 8181 +1
Partials 720 720 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we warn people if they are using this field, rather than failing validation and preventing build? could be annoying if anyone has this just left over in their eas.json and then their build pipeline starts failing with latest eas-cli
sure |
e046460
to
50801dc
Compare
✅ Thank you for adding the changelog entry! |
Why
Global
expo-cli
has been deprecated for a very long time nowHow
don't allow to specify custom global version of deprecated
expo-cli
Test Plan
tests