Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] make CI tsconfig settings match the default local tsconfig settings #2167

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

szdziedzic
Copy link
Member

Why

https://exponent-internal.slack.com/archives/C017N0N99RA/p1704412458848089?thread_ts=1686787194.341989&cid=C017N0N99RA

How

Make the default tsconfig used for the yarn start/yarn build command match the CI one (more strict). Add additional config that allows for unused params and locals. Add the yarn start-allow-unused command to utilize this config.

Test Plan

Run yarn start and yarn start-allow-unused commands locally

@szdziedzic szdziedzic added the no changelog PR that doesn't require a changelog entry label Jan 5, 2024
Copy link

github-actions bot commented Jan 5, 2024

Size Change: -1.98 kB (0%)

Total Size: 55.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 55.5 MB -1.98 kB (0%)

compressed-size-action

Copy link

github-actions bot commented Jan 5, 2024

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eeb143a) 54.21% compared to head (e431407) 54.21%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2167   +/-   ##
=======================================
  Coverage   54.21%   54.21%           
=======================================
  Files         509      509           
  Lines       18670    18670           
  Branches     3741     3741           
=======================================
  Hits        10121    10121           
  Misses       8528     8528           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wschurman wschurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@szdziedzic szdziedzic merged commit bcc5f2b into main Jan 10, 2024
9 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/make-ci-tsconfig-match-default-local-one branch January 10, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants