-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-8956][eas-build] Change tsconfig.json options for easier development #1933
[ENG-8956][eas-build] Change tsconfig.json options for easier development #1933
Conversation
15d93b1
to
a7c9725
Compare
/changelog-entry chore Skip noUnusedLocals and noUnusedParameters during local development |
Size Change: +1.05 kB (0%) Total Size: 41.9 MB
|
Codecov Report
@@ Coverage Diff @@
## main #1933 +/- ##
=======================================
Coverage 52.56% 52.56%
=======================================
Files 479 479
Lines 17358 17358
Branches 3473 3473
=======================================
Hits 9123 9123
Misses 8218 8218
Partials 17 17 |
"compilerOptions": { | ||
"noUnusedLocals": true, | ||
"noUnusedParameters": true | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ment Changed noUnusedLocals and noUnusedParameters to false for easier local development and experimenting. These checks do not run during local development. Instead, `yarn build` catches these cases on github.
37553f7
to
e296c2c
Compare
e296c2c
to
b6a4ca3
Compare
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Why
https://exponent-internal.slack.com/archives/C017N0N99RA/p1686787194341989
How
Changed
noUnusedLocals
andnoUnusedParameters
to false for easier local development and experimenting.These checks do not run during local development. Instead, eslint catches these cases on github.
Test Plan
yarn eas
command that would normally trigger erroryarn lint