Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-8956][eas-build] Change tsconfig.json options for easier development #1933

Conversation

khamilowicz
Copy link
Contributor

Why

https://exponent-internal.slack.com/archives/C017N0N99RA/p1686787194341989

How

Changed noUnusedLocals and noUnusedParameters to false for easier local development and experimenting.
These checks do not run during local development. Instead, eslint catches these cases on github.

Test Plan

  1. Comment out code, import unused method, define unused variable
  2. Run yarn eas command that would normally trigger error
  3. Command should pass
  4. Run yarn lint
  5. It should throw error

@khamilowicz khamilowicz requested a review from szdziedzic as a code owner July 17, 2023 13:27
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-8956-improve-eas-cli-tsconfigjson-for-local-development branch from 15d93b1 to a7c9725 Compare July 17, 2023 13:49
@khamilowicz
Copy link
Contributor Author

/changelog-entry chore Skip noUnusedLocals and noUnusedParameters during local development

@github-actions
Copy link

github-actions bot commented Jul 17, 2023

Size Change: +1.05 kB (0%)

Total Size: 41.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 41.9 MB +1.05 kB (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #1933 (37553f7) into main (57dd372) will not change coverage.
The diff coverage is n/a.

❗ Current head 37553f7 differs from pull request most recent head b6a4ca3. Consider uploading reports for the commit b6a4ca3 to get more accurate results

@@           Coverage Diff           @@
##             main    #1933   +/-   ##
=======================================
  Coverage   52.56%   52.56%           
=======================================
  Files         479      479           
  Lines       17358    17358           
  Branches     3473     3473           
=======================================
  Hits         9123     9123           
  Misses       8218     8218           
  Partials       17       17           

CHANGELOG.md Outdated Show resolved Hide resolved
Comment on lines 3 to 6
"compilerOptions": {
"noUnusedLocals": true,
"noUnusedParameters": true
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most people use yarn watch and yarn build commands for local development. These commands use tsconfig.build.json, so, unfortunately, we don't resolve the issue here.
Screenshot 2023-07-17 at 16 22 04

What I meant was to create 2 different sets of config local and production/ci with different tsconfig and tsconfig.build

…ment

Changed noUnusedLocals and noUnusedParameters to false for easier local development and experimenting.
These checks do not run during local development. Instead, `yarn build` catches these cases on github.
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-8956-improve-eas-cli-tsconfigjson-for-local-development branch from 37553f7 to e296c2c Compare July 17, 2023 15:32
@khamilowicz khamilowicz added the no changelog PR that doesn't require a changelog entry label Jul 17, 2023
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-8956-improve-eas-cli-tsconfigjson-for-local-development branch from e296c2c to b6a4ca3 Compare July 17, 2023 15:38
@github-actions
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@khamilowicz khamilowicz requested a review from szdziedzic July 17, 2023 15:44
@khamilowicz khamilowicz changed the title [ENG-8956][Change] Change tsconfig.json options for easier development [ENG-8956][eas-build] Change tsconfig.json options for easier development Jul 20, 2023
@khamilowicz khamilowicz merged commit e963558 into main Jul 20, 2023
@khamilowicz khamilowicz deleted the piotrekszeremeta/eng-8956-improve-eas-cli-tsconfigjson-for-local-development branch July 20, 2023 14:35
szdziedzic added a commit that referenced this pull request Jan 5, 2024
szdziedzic added a commit that referenced this pull request Jan 10, 2024
…ettings (#2167)

* Revert "[ENG-8956][eas-build]  Improve EAS CLI tsconfig.json for local development (#1933)"

This reverts commit e963558.

* add start-allow-unused option

* update CONTRIBUTING.md

* fix type error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants