-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Remove semver validation from node version read from .nvmrc #2052
[FIX] Remove semver validation from node version read from .nvmrc #2052
Conversation
Node version can be specified as an alias (such as `iojs`, `lts/hydrogen` etc), so validating it as semver may cause errors for some users.
/changelog-entry bug-fix Support node aliases in |
1e2a6e9
to
a9b4ee7
Compare
/changelog-entry bug-fix Support node aliases in .nvmrc. |
d78e4f4
to
710270e
Compare
✅ Thank you for adding the changelog entry! |
Size Change: +187 B (0%) Total Size: 42.3 MB
|
Codecov Report
@@ Coverage Diff @@
## main #2052 +/- ##
==========================================
- Coverage 53.98% 53.98% -0.00%
==========================================
Files 508 508
Lines 18596 18593 -3
Branches 3911 3910 -1
==========================================
- Hits 10037 10035 -2
+ Misses 8539 8538 -1
Partials 20 20
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check that values like lts
would still install successfully on our backend?
@szdziedzic yep |
Why
#1975 (comment)
Node version can be specified as an alias (such as
iojs
,lts/hydrogen
etc), so validating it as semver may cause errors for some users.How
Remove validation
Test Plan
Specify node version in
.nvmrc
as something likelts/gallium
and run build.