Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Remove semver validation from node version read from .nvmrc #2052

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

khamilowicz
Copy link
Contributor

@khamilowicz khamilowicz commented Sep 13, 2023

Why

#1975 (comment)
Node version can be specified as an alias (such as iojs, lts/hydrogen etc), so validating it as semver may cause errors for some users.

How

Remove validation

Test Plan

Specify node version in .nvmrc as something like lts/gallium and run build.

Node version can be specified as an alias (such as `iojs`, `lts/hydrogen` etc), so validating it as semver may cause errors for some users.
@khamilowicz
Copy link
Contributor Author

/changelog-entry bug-fix Support node aliases in .nvmrc.

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/dont-validate-node-version branch from 1e2a6e9 to a9b4ee7 Compare September 13, 2023 14:40
@khamilowicz
Copy link
Contributor Author

/changelog-entry bug-fix Support node aliases in .nvmrc.

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/dont-validate-node-version branch from d78e4f4 to 710270e Compare September 13, 2023 14:45
@github-actions
Copy link

✅ Thank you for adding the changelog entry!

@github-actions
Copy link

Size Change: +187 B (0%)

Total Size: 42.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 42.3 MB +187 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #2052 (710270e) into main (da9829a) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2052      +/-   ##
==========================================
- Coverage   53.98%   53.98%   -0.00%     
==========================================
  Files         508      508              
  Lines       18596    18593       -3     
  Branches     3911     3910       -1     
==========================================
- Hits        10037    10035       -2     
+ Misses       8539     8538       -1     
  Partials       20       20              
Files Changed Coverage Δ
packages/eas-cli/src/utils/profiles.ts 92.60% <ø> (+1.37%) ⬆️

Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that values like lts would still install successfully on our backend?

@khamilowicz
Copy link
Contributor Author

@szdziedzic yep
image

@khamilowicz khamilowicz merged commit 7ddd630 into main Sep 18, 2023
9 checks passed
@khamilowicz khamilowicz deleted the piotrekszeremeta/dont-validate-node-version branch September 18, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants