Skip to content

Commit

Permalink
[ENG-5266] Suggest correct bundleId when account name not available (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
khamilowicz authored Sep 11, 2023
1 parent cc822b1 commit da9829a
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion packages/eas-cli/src/project/ios/bundleIdentifier.ts
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,14 @@ async function getSuggestedBundleIdentifierAsync(
} else {
// the only callsite is heavily interactive
const account = await getOwnerAccountForProjectIdAsync(graphqlClient, projectId);
let possibleId: string;
// It's common to use dashes in your node project name, strip them from the suggested package name.
const possibleId = `com.${account.name}.${exp.slug}`.split('-').join('');
if (account.name) {
possibleId = `com.${account.name}.${exp.slug}`.split('-').join('');
} else {
possibleId = `com.${exp.slug}`.split('-').join('');
}

if (isBundleIdentifierValid(possibleId)) {
return possibleId;
}
Expand Down

0 comments on commit da9829a

Please sign in to comment.