[eas-cli] Only create a channel with branch name when branch is created

[byCedric]

Checklist

• I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why

I noticed that whenever you have your own custom branch/channels mapping set up, it still created a new channel with that same branch name. Even when it's not necessary. This change was introduced in PR #1478, while trying to better surface important behavior within the command (instead of obfuscating it in side utility functions)

How

Preferably, I would implement something like:

const existingBranch = BranchQuery.getBranchByName({ name });
if (!existingBranch) {
  // create channel
}

But we throw errors in that case, which makes implementing this a bit harder. Instead, I opted for a isCreated boolean in the ensureBranchExists utility class.

Test Plan

Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.

[github-actions]

Size Change: -2.89 kB (0%)

Total Size: 40.3 MB

Filename	Size	Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz	40.3 MB	-2.89 kB (0%)

_{compressed-size-action}

[codecov]

Codecov Report

Merging #1507 (4c7886c) into main (597e012) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 4c7886c differs from pull request most recent head 832f65c. Consider uploading reports for the commit 832f65c to get more accurate results

@@            Coverage Diff             @@
##             main    #1507      +/-   ##
==========================================
- Coverage   51.49%   51.49%   -0.00%     
==========================================
  Files         454      454              
  Lines       15675    15676       +1     
  Branches     3087     3088       +1     
==========================================
  Hits         8071     8071              
- Misses       7590     7591       +1     
  Partials       14       14              

Impacted Files	Coverage Δ
packages/eas-cli/src/branch/queries.ts	22.96% <0.00%> (ø)
packages/eas-cli/src/commands/update/index.ts	14.91% <0.00%> (-0.05%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dsokal]

Nit: branchIsCreated -> createdBranch. Maybe this is me but branchIsCreated should be always true after calling ensureBranchExistsAsync.

[byCedric]

Nit: branchIsCreated -> createdBranch. Maybe this is me but branchIsCreated should be always true after calling ensureBranchExistsAsync.

Makes sense, done!

[byCedric]

/changelog-entry bug-fix Only create a new channel when update branch is new

[kbrandwijk]

This addresses https://linear.app/expo/issue/ENG-6159/do-not-auto-create-channel-when-publishing