-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Extract entity utilities from update command class #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -160 B (0%) Total Size: 40.1 MB
|
Open questions to everyone here:
|
Codecov Report
@@ Coverage Diff @@
## main #1478 +/- ##
==========================================
+ Coverage 51.13% 51.15% +0.02%
==========================================
Files 450 450
Lines 15492 15492
Branches 3045 3045
==========================================
+ Hits 7921 7923 +2
+ Misses 7558 7556 -2
Partials 13 13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
byCedric
requested review from
wschurman,
dsokal and
wkozyra95
as code owners
October 25, 2022 15:13
byCedric
changed the title
@bycedric/updates/refactor ensure helpers
[eas-cli] Extract entity utilities from update command class
Oct 25, 2022
wschurman
approved these changes
Oct 25, 2022
byCedric
force-pushed
the
@bycedric/updates/input-refactor
branch
from
October 28, 2022 16:03
48eec6d
to
1983d52
Compare
byCedric
force-pushed
the
@bycedric/updates/refactor-ensure-helpers
branch
from
October 28, 2022 16:10
4a7c9d6
to
40657ba
Compare
…sy values Co-authored-by: Will Schurman <[email protected]>
…y on falsy values" This reverts commit 23ac36d.
…alsy values" This reverts commit 94ae7cc.
byCedric
force-pushed
the
@bycedric/updates/refactor-ensure-helpers
branch
from
October 31, 2022 17:32
40657ba
to
e1a1c88
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/changelog-entry [breaking-change|new-feature|bug-fix|chore] [message]
and CHANGELOG.md will be updated automatically.Why
Continuation of PR #1473 and ENG-5926.
How
UpdatePublish
tosrc/branch|channel/queries.ts
.BranchCreate
andChannelCreate
, to keep queries contained insrc/branch|channel/queries.ts
files.Created branch: <branchName>
Created a channel: <channelName> pointed at branch: <branchName>
(only logged when created)Channel: <channelName> pointed at branch: <branchName>
(always logged)Log.withTick
)Test Plan
eas update --branch new-branch
eas update --branch existing-branch