Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required maximum version of typing-extensions #833

Merged

Conversation

albertvillanova
Copy link
Contributor

@albertvillanova albertvillanova commented Dec 30, 2022

This PR fixes the required maximum version of typing-extensions.

Currently it is bounded to <4.2.0: typing_extensions>=3.7.4.1,<4.2.0; python_version < "3.8"

This PR sets the upper bound to all compatible versions, until the next major release <5.0.0.

Required:

See:

See issue in pydantic:

See fixing PR in pydantic (typing-extensions>=4.2.0), which will be incompatible with your requirement typing_extensions>=3.7.4,<4.2.0; python_version < "3.8":

@albertvillanova
Copy link
Contributor Author

The failing CI tests should be fixed once

merged and released.

@svlandeg
Copy link
Member

svlandeg commented Jan 2, 2023

Thanks for the PR and the context, we appreciate it!

As Pydantic 1.10.3 has been yanked, 1.10.2 should still work fine with spaCy and users shouldn't be impacted anymore. We'll talk internally whether we want to raise to <5.0.0 or perhaps something a little more restrictive like <4.5.0.

Putting in draft until confection is fixed.

@svlandeg svlandeg marked this pull request as draft January 2, 2023 10:32
@svlandeg svlandeg added the install Installation and compilation label Jan 2, 2023
requirements.txt Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@adrianeboyd
Copy link
Contributor

We'll have to rerun the CI after the PyPI timeout issues are resolved.

@adrianeboyd adrianeboyd marked this pull request as ready for review January 10, 2023 13:39
@adrianeboyd adrianeboyd merged commit 4ad911c into explosion:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
install Installation and compilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants