Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required maximum version of typing-extensions #20

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

albertvillanova
Copy link
Contributor

@albertvillanova albertvillanova commented Dec 30, 2022

This PR fixes the required maximum version of typing-extensions.

Currently it is bounded to <4.2.0: typing_extensions>=3.7.4.1,<4.2.0; python_version < "3.8"

This PR sets the upper bound to all compatible versions, until the next major release <5.0.0.

See:

See issue in pydantic:

See fixing PR in pydantic (typing-extensions>=4.2.0), which will be incompatible with your requirement typing_extensions>=3.7.4,<4.2.0; python_version < "3.8":

@albertvillanova albertvillanova changed the title Fix required minimum version of typing-extensions Fix required maximum version of typing-extensions Dec 30, 2022
@svlandeg
Copy link
Member

svlandeg commented Jan 2, 2023

Thanks for the PR and the context, we appreciate it!

As Pydantic 1.10.3 has been yanked, 1.10.2 should still work fine with spaCy and users shouldn't be impacted anymore. We'll talk internally whether we want to raise to <5.0.0 or perhaps something a little more restrictive like <4.5.0.

requirements.txt Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@adrianeboyd
Copy link
Contributor

I don't know whether we want to additionally forbid pydantic v1.10.3. Yanked packages aren't always supported correctly (poetry only added support quite recently), but we also don't typically forbid packages for this kind of reason, usually only if there are security vulnerabilities or it's broken across the board.

@adrianeboyd adrianeboyd merged commit 6b51373 into explosion:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants