Hamming: Updates canonical-data.json to comply with schema #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSchierboom
requested changes
Aug 8, 2017
There was a problem hiding this comment.
This looks good, but you should also be updating the version. For more information, see: https://github.com/exercism/problem-specifications#test-data-versioning
|
@ErikSchierboom, thanks for pointing out to the issue. |
|
@m-a-ge No problem! Thanks for taking the effort to do a PR. |
stevejb71
reviewed
Aug 8, 2017
| @@ -110,14 +110,14 @@ | |||
| "property": "distance", | |||
| "strand1": "AATG", | |||
| "strand2": "AAA", | |||
| "expected": -1 | |||
| "expected": {"error": "leftStrand and rightStrand must be of equal length"} | |||
There was a problem hiding this comment.
leftStrand looks a bit like a Java parameter name. How about 'left strand'? Or 'strands are of different lengths'?
There was a problem hiding this comment.
It makes sense, will change it as well
rpottsoh
changed the title
|
@ErikSchierboom, I've made requested changes, verify please 👮 |
petertseng
added a commit
to petertseng/exercism-ceylon
that referenced
this pull request
Oct 4, 2017
No additional action needs to be taken; we were already expecting an error for the cases of unequal length (which is what 2.0.0 provides). exercism/problem-specifications#875
petertseng
added a commit
to exercism/ceylon
that referenced
this pull request
Oct 4, 2017
No additional action needs to be taken; we were already expecting an error for the cases of unequal length (which is what 2.0.0 provides). exercism/problem-specifications#875
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
Make Acronym unlock WordCount
ZapAnton
added a commit
to ZapAnton/rust
that referenced
this pull request
Nov 20, 2018
Relevant PRs: - exercism/problem-specifications#625 - exercism/problem-specifications#844 - exercism/problem-specifications#845 - exercism/problem-specifications#875 - exercism/problem-specifications#953 - exercism/problem-specifications#1129 - exercism/problem-specifications#1389 Basically adds every test case from the current canonical-data.json without deleting the old ones.
ZapAnton
added a commit
to ZapAnton/rust
that referenced
this pull request
Nov 21, 2018
Relevant PRs: 1) Test cases: - exercism/problem-specifications#625 - exercism/problem-specifications#844 - exercism/problem-specifications#845 - exercism/problem-specifications#875 - exercism/problem-specifications#953 - exercism/problem-specifications#1129 - exercism/problem-specifications#1389 2) README: - exercism/problem-specifications#1360 Basically adds every test case from the current canonical-data.json without deleting the old ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #812