Hamming: Description.md, language simplification #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpottsoh
changed the title
rpottsoh
requested changes
Oct 8, 2018
|
@rpottsoh Updated. Thanks :) |
rpottsoh
approved these changes
Oct 8, 2018
petertseng
reviewed
Oct 8, 2018
There was a problem hiding this comment.
interesting thing - before this PR there were two instances of "Hamming distance" and one instance of "Hamming difference".
After this PR there would be one instance of "Hamming distance" and three of "hamming difference".
I suggest that this would be a good time to discuss whether:
- This PR is a good time to change to using just one of those two options
- It is good to use just one of those two options, but can just file an issue for it and don't need to do it in this PR
- It is good to use both of these options, therefore no changes need be made here
|
Nice catch @petertseng. I think it should be hamming distance. Search for hamming difference yields hamming distance.... |
|
Happy to change it to "hamming distance" everywhere. |
I'm also in favor of using "hamming distance". |
|
I've added another commit (we can squash on merge). |
rpottsoh
approved these changes
Oct 10, 2018
ErikSchierboom
approved these changes
Oct 10, 2018
|
Thanks @iHiD! |
|
Great. Thanks, all. |
petertseng
pushed a commit
to petertseng/exercism-ceylon
that referenced
this pull request
Nov 1, 2018
ZapAnton
added a commit
to ZapAnton/rust
that referenced
this pull request
Nov 21, 2018
Relevant PRs: 1) Test cases: - exercism/problem-specifications#625 - exercism/problem-specifications#844 - exercism/problem-specifications#845 - exercism/problem-specifications#875 - exercism/problem-specifications#953 - exercism/problem-specifications#1129 - exercism/problem-specifications#1389 2) README: - exercism/problem-specifications#1360 Basically adds every test case from the current canonical-data.json without deleting the old ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With reference to exercism/exercism#4155 (comment) I propose making the language of this exercise easier for non-english speakers.