-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format and lint #894
Format and lint #894
Conversation
Has been fixed since #645, but the file was still ignoring directories.
@SleeplessByte This is so good! 💚
Do we need the Will CI check for lint be added in separate PR? |
I didn't yet decide if we wanted to add it by default, but first wanted to see your reaction hehehehe. I'll add it to the maintainers workflow and I'll add the CI. We already have it for v3, so easy copy. |
This file has been replaced by npx babel-node scripts/lint
This file has been replaced by npx babel-node scripts/test
These have been replaced by npx babel-node sync
In reality, code formatted between version 2.x and 2.y is going to be very similar if not the same, so most of the time prettier will "just work" in editors. We just don't want to auto-install a version that has to be kept in sync with the repo unless that's necessary. We can later decide to add it as Bonus. On any future pr, add a comment with:
and it will auto-format the code and commit it. No need to install/run anything. EXAMPLE: #839 (comment) |
Amazing work @SleeplessByte 👍 |
simple-linked-list
)