Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve zipper tests #839

Merged
merged 3 commits into from
Dec 24, 2020
Merged

improve zipper tests #839

merged 3 commits into from
Dec 24, 2020

Conversation

joshgoebel
Copy link
Contributor

@joshgoebel joshgoebel commented Mar 8, 2020 •
edited
Loading

Resolves #838

@joshgoebel
Copy link
Contributor Author

@SleeplessByte Like this?

@SleeplessByte
Copy link
Member

Yeah, this looks fine. Maybe also add the README change through a hint!

@joshgoebel
Copy link
Contributor Author

I'm not sure exactly what you want it to say, but you're welcome to edit it and add whatever.

@SleeplessByte
Copy link
Member

It's in #838 (comment) . Basically explain the JS implementation (tree) yadayada

@SleeplessByte
Copy link
Member

/format

@github-actions
Copy link
Contributor

The "Format code" action has started running.

@github-actions
Copy link
Contributor

The "Format code" action has finished running.

@github-actions
Copy link
Contributor

For security reasons, /format does not trigger CI builds when the PR has been submitted from a fork. If checks were not passing due to code format, trigger a build to make the required checks pass, through one of the following ways:

  • Push an empty commit to this branch: git commit --allow-empty -m "Trigger builds".
  • Close and reopen the PR.
  • Push a regular commit to this branch.

@SleeplessByte SleeplessByte reopened this Dec 16, 2020
@SleeplessByte SleeplessByte mentioned this pull request Dec 16, 2020
Merged
@SleeplessByte SleeplessByte merged commit 536eda4 into exercism:master Dec 24, 2020
@SleeplessByte SleeplessByte mentioned this pull request Dec 28, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessByte SleeplessByte SleeplessByte approved these changes

Assignees
No one assigned
Labels
new test case ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests for Zipper are far from sufficient
2 participants
@joshgoebel @SleeplessByte