Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch_configlet: update, and remove duplicate script #1218

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Oct 20, 2022

Commit eff52e6 "Update bin/fetch-configlet script" added a new up-to-date fetch script, rather than modifying the existing one.

Remove the new script, and update the old one with the same upstream changes:

  • 3815d7a fetch-configlet: allow running from the bin directory
  • d304fa5 fetch-configlet: add comment with upstream location
  • 9c69c4d fetch-configlet: remove a hard line wrap
  • 3b4b009 fetch-configlet: improve style slightly

Follow-up from #1217.

Alternatively, we could also remove the .sh script instead. But if we prefer the extensionless name, maybe it's better to merge this PR first, then remove all .sh from scripts in this repo as a follow-up PR.

Commit eff52e6 "Update bin/fetch-configlet script" added a new
up-to-date fetch script, rather than modifying the existing one.

Remove the new script, and update the old one with the same upstream
changes [1][2][3][4]:

- fetch-configlet: allow running from the bin directory
- fetch-configlet: add comment with upstream location
- fetch-configlet: remove a hard line wrap
- fetch-configlet: improve style slightly

[1] exercism/configlet@3815d7a11ece
[2] exercism/configlet@d304fa5f4291
[3] exercism/configlet@9c69c4d40827
[4] exercism/configlet@3b4b00983ac6
@ee7 ee7 requested a review from a team as a code owner October 20, 2022 16:13
@github-actions
Copy link
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps
    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)

Automated comment created by PR Commenter 🤖.

@kytrinyx
Copy link
Member

Alternatively, we could also remove the .sh script instead. But if we prefer the extensionless name, maybe it's better to merge this PR first, then remove all .sh from scripts in this repo as a follow-up PR.

I would prefer the fetch-configlet script to be the same across all repositories. I will be adding it to the org-wide-files repository shortly. (I should have done that before making all these PRs; it didn't occur to me).

I don't feel strongly about having the script be extensionless, though. That's just an artifact of an earlier choice that I made without having strong feelings about the options.

Copy link
Member

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with merging this and then changing the extensions in a follow-on PR, if that is the outcome of the discussion.

@ee7
Copy link
Member Author

ee7 commented Oct 20, 2022

I will be adding it to the org-wide-files repository shortly.

Sounds good to me. I think we intended to get around to doing that.

If we change the filename in this repo (which we would do if we add this file to org-wide-files) we should remember to update the filename in CODEOWNERS:

# Changes to `fetch-configlet` should be made in the `exercism/configlet` repo
bin/fetch_configlet.sh @exercism/maintainers-admin

@jiegillet
Copy link
Contributor

OK then, I'll merge this and expect a follow up PR with a name change (I do have a slight preference for having an extension).
Thank you.

@jiegillet jiegillet merged commit acca6dd into exercism:main Oct 21, 2022
@ee7 ee7 deleted the fetch-configlet-remove-duplicate branch October 21, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants