Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bin/fetch-configlet script #1217

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Update bin/fetch-configlet script #1217

merged 1 commit into from
Oct 20, 2022

Conversation

kytrinyx
Copy link
Member

The script has been tweaked to work better across all platforms.

Ref exercism/exercism#6591

The script has been tweaked to work better across all platforms.
@github-actions
Copy link
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps
    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)

Automated comment created by PR Commenter 🤖.

@jiegillet jiegillet merged commit eff52e6 into main Oct 20, 2022
@jiegillet jiegillet deleted the update-fetch-configlet branch October 20, 2022 13:31
@ee7
Copy link
Member

ee7 commented Oct 20, 2022

Note that this PR added a new script, rather than editing the existing bin/fetch_configlet.sh (which has an underscore, and a file extension).

I created #1218, but we could also do the opposite thing.

I think we can either:

  • Allow tracks to name the script whatever they want (perhaps for some internally consistent script-naming style) and when mass-updating fetch-configlet scripts, ensure that we detect the repo-specific filename.
  • Force every repo to use the same filename for the fetch-configlet script.

I don't mind, as long as we don't have multiple scripts in the same repo.

@ee7
Copy link
Member

ee7 commented Oct 20, 2022

@kytrinyx I think the Elixir track is the main such case, but please double-check.

$ paths="$(rg --sort path --files-with-matches 'https://api.github.com/repos/exercism/configlet/releases/latest')"
$ echo "${paths}"
05ab1e/bin/fetch-configlet
abap/bin/fetch-configlet
abap/bin/fetch-configlet.ps1
ada/bin/fetch-configlet
arm64-assembly/bin/fetch-configlet
awk/bin/fetch-configlet
awk/bin/fetch-configlet.ps1
babashka/bin/fetch-configlet
ballerina/bin/fetch-configlet
bash/bin/fetch-configlet
bqn/bin/fetch-configlet
bqn/bin/fetch-configlet.ps1
c/bin/fetch-configlet
ceylon/bin/fetch-configlet
cfml/bin/fetch-configlet
chapel/bin/fetch-configlet
chapel/bin/fetch-configlet.ps1
clojure/bin/fetch-configlet
clojurescript/bin/fetch-configlet
cobol/bin/fetch-configlet
cobol/bin/fetch-configlet.ps1
coffeescript/bin/fetch-configlet
common-lisp/bin/fetch-configlet
coq/bin/fetch-configlet
cpp/bin/fetch-configlet
cpp/bin/fetch-configlet.ps1
crystal/bin/fetch-configlet
d/bin/fetch-configlet
dart/bin/fetch-configlet
dart/bin/fetch-configlet.ps1
delphi/bin/fetch-configlet
elixir/bin/fetch_configlet.sh
elm/bin/fetch-configlet
emacs-lisp/bin/fetch-configlet
erlang/bin/fetch-configlet
factor/bin/fetch-configlet
forth/bin/fetch-configlet
fortran/bin/fetch-configlet
fortran/bin/fetch_configlet.py
free-pascal/bin/fetch-configlet
free-pascal/bin/fetch-configlet.ps1
gleam/bin/fetch-configlet
gnu-apl/bin/fetch-configlet
gnucobol/bin/fetch-configlet
gnucobol/bin/fetch-configlet.ps1
go/bin/fetch-configlet
haskell/bin/fetch-configlet
haxe/bin/fetch-configlet
idris/bin/fetch-configlet
io/bin/fetch-configlet
j/bin/fetch-configlet
java/bin/fetch-configlet
javascript/bin/fetch-configlet
javascript/bin/fetch-configlet.ps1
jq/bin/fetch-configlet
jq/bin/fetch-configlet.ps1
julia/bin/fetch-configlet
kotlin/bin/fetch-configlet
lfe/bin/fetch-configlet
lua/bin/fetch-configlet
mips/bin/fetch-configlet
nim/bin/fetch-configlet
nix/bin/fetch-configlet
objective-c/bin/fetch-configlet
ocaml/bin/fetch-configlet
openeuphoria/bin/fetch-configlet
openeuphoria/bin/fetch-configlet.ps1
perl5/bin/fetch-configlet
pharo-smalltalk/bin/fetch-configlet
php/bin/fetch-configlet
plsql/bin/fetch-configlet
pony/bin/fetch-configlet
powershell/bin/fetch-configlet
prolog/bin/fetch-configlet
purescript/bin/fetch-configlet
python/bin/fetch-configlet
qsharp/bin/fetch-configlet
qsharp/bin/fetch-configlet.ps1
r/bin/fetch-configlet
racket/bin/fetch-configlet
raku/bin/fetch-configlet
reasonml/bin/fetch-configlet
red/bin/fetch-configlet
red/bin/fetch-configlet.ps1
ruby/bin/fetch-configlet
rust/bin/fetch-configlet
rust/util/exercise/src/cmd/fetch_configlet.rs
scala/bin/fetch-configlet
scheme/bin/fetch-configlet
shen/bin/fetch-configlet
sml/bin/fetch-configlet
solidity/bin/fetch-configlet
solidity/bin/fetch-configlet.ps1
swift/bin/fetch-configlet
system-verilog/bin/fetch-configlet
tcl/bin/fetch-configlet
typescript/bin/fetch-configlet
typescript/bin/fetch-configlet.ps1
unison/bin/fetch-configlet
unison/bin/fetch-configlet.ps1
vimscript/bin/fetch-configlet
vlang/bin/fetch-configlet
vlang/bin/fetch-configlet.ps1
wasm/bin/fetch-configlet
wasm/bin/fetch-configlet.ps1
wren/bin/fetch-configlet
wren/bin/fetch-configlet.ps1
x86-64-assembly/bin/fetch-configlet
z3/bin/fetch-configlet
z3/bin/fetch-configlet.ps1
zig/bin/fetch-configlet
zig/bin/fetch-configlet.ps1
$ echo "${paths}" | grep -v '.*bin/fetch-configlet[\.ps1]*$'
elixir/bin/fetch_configlet.sh
fortran/bin/fetch_configlet.py
rust/util/exercise/src/cmd/fetch_configlet.rs

@jiegillet
Copy link
Contributor

I didn't notice the name was different, my bad.
I'm not sure why we had a different name, but personally, I'm in favor of forcing all tracks to have the same name, it's just easier to centralize these things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants