Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#1731] Replace TSC build constant + Simplify version generation #2053

Merged
merged 3 commits into from
Oct 21, 2021
Merged

fix: [#1731] Replace TSC build constant + Simplify version generation #2053

merged 3 commits into from
Oct 21, 2021

Conversation

eonarheim
Copy link
Member

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • [NA] 📐 new tests written and passing / old tests updated with new scenario(s)
  • [NA] 📄 changelog entry added (or not needed)

==================

Closes: #1731

Changes:

  • Updates the versioning process to not rely on git tags
  • Replaces the unprocessed constant in build/dist/index.js

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Oct 4, 2021
kamranayub
kamranayub reviewed Oct 8, 2021
View reviewed changes
Copy link
Member

@kamranayub kamranayub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

package.json Show resolved Hide resolved
scripts/excalibur-version.js Show resolved Hide resolved
@kamranayub
Copy link
Member

@eonarheim do you have an example/test of this working in runtime bundle? 👍

@eonarheim
Copy link
Member Author

@eonarheim do you have an example/test of this working in runtime bundle? 👍

Here is the replacement in action locally

image

Actually I think this will be more useful with the esm modules...

@kamranayub
Copy link
Member

Nice!

@kamranayub kamranayub merged commit a2a245e into main Oct 21, 2021
@kamranayub kamranayub deleted the fix/1731-version-constant branch October 21, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamranayub kamranayub kamranayub approved these changes

Assignees
No one assigned
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unprocessed version constant in es module
2 participants
@eonarheim @kamranayub