Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unprocessed version constant in es module #1731

Closed
eonarheim opened this issue Dec 21, 2020 · 3 comments · Fixed by #2053
Closed

Unprocessed version constant in es module #1731

eonarheim opened this issue Dec 21, 2020 · 3 comments · Fixed by #2053
Assignees
@kamranayub
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior stale This issue or PR has not had any activity recently
Milestone
vNext

Comments

@eonarheim
Copy link
Member

Steps to Reproduce

When excalibur builds es modules, it does not inline the version. In the UMD bundle it does.

#1729 (reply in thread)

Expected Result

Excalibur version should be present

Actual Result

Invalid syntax for the browser is present

Environment

  • browsers and versions: N/A
  • operating system: N/A
  • Excalibur versions: Latest

Current Workaround

None
@eonarheim eonarheim added the bug This issue describes undesirable, incorrect, or unexpected behavior label Dec 21, 2020
@github-actions
Copy link

This issue hasn't had any recent activity lately and is being marked as stale automatically.

@github-actions github-actions bot added the stale This issue or PR has not had any activity recently label Feb 20, 2021
@kamranayub kamranayub self-assigned this Mar 6, 2021
@kamranayub
Copy link
Member

Working on this

@kamranayub kamranayub removed the stale This issue or PR has not had any activity recently label Mar 6, 2021
@github-actions
Copy link

github-actions bot commented May 6, 2021

This issue hasn't had any recent activity lately and is being marked as stale automatically.

@github-actions github-actions bot added the stale This issue or PR has not had any activity recently label May 6, 2021
eonarheim added a commit that referenced this issue Oct 4, 2021
@eonarheim
fix: [#1731] Replace TSC build constant + Simplify version generation
4d22145 
Closes: #1731
@eonarheim eonarheim mentioned this issue Oct 4, 2021
Merged
3 tasks
@jedeen jedeen added this to the vNext milestone Oct 9, 2021
kamranayub pushed a commit that referenced this issue Oct 21, 2021
@eonarheim
fix: [#1731] Replace TSC build constant + Simplify version generation (…
a2a245e 
…#2053)

* fix: [#1731] Replace TSC build constant + Simplify version generation

Closes: #1731

* fix: lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamranayub kamranayub

Labels
bug This issue describes undesirable, incorrect, or unexpected behavior stale This issue or PR has not had any activity recently
Projects
None yet
Milestone
vNext
Development

Successfully merging a pull request may close this issue.

fix: [#1731] Replace TSC build constant + Simplify version generation excaliburjs/Excalibur
3 participants
@kamranayub @eonarheim @jedeen