Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add histogram-based metrics #445

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Add histogram-based metrics #445

merged 2 commits into from
Sep 25, 2024

Conversation

vilunov
Copy link
Contributor

@vilunov vilunov commented Sep 25, 2024 •
edited
Loading

No description provided.

@vilunov
Add histogram-based metrics (evolution-gaming#440)
a310fbe 
* Extract ProducerMetrics implementations into named classes

* Add Histograms implementation for ProducerMetrics

* Extract ConsumerMetrics implementations into named classes

* Add Histogram implementation of ConsumerMetrics

* Name Throwables in MonadCancel

* Docs for latencyBuckets

* Apply suggestions from code review

Co-authored-by: Mareks Rampāns <[email protected]>

* Update skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala

Co-authored-by: Mareks Rampāns <[email protected]>

* changed name

* fix scala 3

* Apply suggestions from code review

Co-authored-by: Mareks Rampāns <[email protected]>

* bump minor version

---------

Co-authored-by: Mareks Rampāns <[email protected]>
Co-authored-by: Denys Fakhritdinov <[email protected]>

(cherry picked from commit 0b37012)
@vilunov
bump stuff
67eceeb
@coveralls
Copy link

coveralls commented Sep 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11030715957

Details

  • 51 of 161 (31.68%) changed or added relevant lines in 2 files are covered.
  • 14 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-2.9%) to 72.675%
Changes Missing Coverage Covered Lines Changed/Added Lines %
skafka/src/main/scala/com/evolutiongaming/skafka/producer/ProducerMetrics.scala 25 74 33.78%
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala 26 87 29.89%
Files with Coverage Reduction New Missed Lines %
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/RebalanceCallback.scala 1 97.32%
skafka/src/main/scala/com/evolutiongaming/skafka/OffsetAndMetadata.scala 1 83.33%
modules/metrics/src/main/scala/com/evolutiongaming/skafka/metrics/KafkaMetricsCollector.scala 1 0.0%
skafka/src/main/scala/com/evolutiongaming/skafka/producer/ProducerLogging.scala 2 44.0%
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/RebalanceListener.scala 3 18.18%
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerLogging.scala 6 84.76%
Totals Coverage Status
Change from base Build 11014924004: -2.9%
Covered Lines: 1383
Relevant Lines: 1903
💛 - Coveralls

@dfakhritdinov dfakhritdinov merged commit 46ee112 into evolution-gaming:ce2 Sep 25, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfakhritdinov dfakhritdinov dfakhritdinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vilunov @coveralls @dfakhritdinov