Add histogram-based metrics #440

vilunov · 2024-09-23T10:02:33Z

No description provided.

Phill101

lgtm

skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala

mr-git · 2024-09-23T11:03:03Z

what is the goal?

did I understood correctly, that goal is to provide option to use either Summary or Histogram based metrics?

mr-git · 2024-09-23T11:06:52Z

LGTM, though I paid more attention from perspective of next developer

skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala

skafka/src/main/scala/com/evolutiongaming/skafka/producer/ProducerMetrics.scala

mr-git · 2024-09-23T12:49:47Z

As a next developer, I'd like to see more details in metrics help strings, like what are the possible values in some cases, where it is not obvious what there could be.

Please review help strings critically and improve where it is due.

Co-authored-by: Mareks Rampāns <[email protected]>

…umerMetrics.scala Co-authored-by: Mareks Rampāns <[email protected]>

skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala

coveralls · 2024-09-24T12:40:40Z

Pull Request Test Coverage Report for Build 11029572465

Details

28 of 193 (14.51%) changed or added relevant lines in 3 files are covered.
954 unchanged lines in 46 files lost coverage.
Overall coverage decreased (-1.8%) to 92.633%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
modules/metrics/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetricsOf.scala	0	12	0.0%
skafka/src/main/scala/com/evolutiongaming/skafka/producer/ProducerMetrics.scala	16	89	17.98%
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala	12	92	13.04%

Files with Coverage Reduction	New Missed Lines	%
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/WithSize.scala	1	66.67%
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerRecords.scala	1	90.91%
skafka/src/main/scala/com/evolutiongaming/skafka/SecurityProtocol.scala	1	60.0%
skafka/src/main/scala/com/evolutiongaming/skafka/producer/CreateProducerJ.scala	1	75.0%
modules/play-json/src/main/scala/com/evolutiongaming/skafka/producer/JsonProducer.scala	2	66.67%
skafka/src/main/scala/com/evolutiongaming/skafka/KeystoreType.scala	2	44.44%
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/RebalanceListener1.scala	2	50.0%
skafka/src/main/scala/com/evolutiongaming/skafka/producer/RecordMetadata.scala	2	66.67%
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/RebalanceListener.scala	2	33.33%
modules/play-json/src/main/scala/com/evolutiongaming/skafka/producer/ToBytesFromWrites.scala	2	0.0%

Totals
Change from base Build 11013160085:	-1.8%
Covered Lines:	2540
Relevant Lines:	2742

💛 - Coveralls

skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala

skafka/src/main/scala/com/evolutiongaming/skafka/producer/ProducerMetrics.scala

Co-authored-by: Mareks Rampāns <[email protected]>

* Extract ProducerMetrics implementations into named classes * Add Histograms implementation for ProducerMetrics * Extract ConsumerMetrics implementations into named classes * Add Histogram implementation of ConsumerMetrics * Name Throwables in MonadCancel * Docs for latencyBuckets * Apply suggestions from code review Co-authored-by: Mareks Rampāns <[email protected]> * Update skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala Co-authored-by: Mareks Rampāns <[email protected]> * changed name * fix scala 3 * Apply suggestions from code review Co-authored-by: Mareks Rampāns <[email protected]> * bump minor version --------- Co-authored-by: Mareks Rampāns <[email protected]> Co-authored-by: Denys Fakhritdinov <[email protected]> (cherry picked from commit 0b37012)

* Add histogram-based metrics (#440) * Extract ProducerMetrics implementations into named classes * Add Histograms implementation for ProducerMetrics * Extract ConsumerMetrics implementations into named classes * Add Histogram implementation of ConsumerMetrics * Name Throwables in MonadCancel * Docs for latencyBuckets * Apply suggestions from code review Co-authored-by: Mareks Rampāns <[email protected]> * Update skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala Co-authored-by: Mareks Rampāns <[email protected]> * changed name * fix scala 3 * Apply suggestions from code review Co-authored-by: Mareks Rampāns <[email protected]> * bump minor version --------- Co-authored-by: Mareks Rampāns <[email protected]> Co-authored-by: Denys Fakhritdinov <[email protected]> (cherry picked from commit 0b37012) * bump stuff

vilunov added 5 commits September 22, 2024 09:52

Extract ProducerMetrics implementations into named classes

c135e6f

Add Histograms implementation for ProducerMetrics

c2d0302

Extract MapK into a named class

20c6214

Extract ConsumerMetrics implementations into named classes

52b1e14

Add Histogram implementation of ConsumerMetrics

9c7549d

Phill101 self-requested a review September 23, 2024 10:07

Phill101 approved these changes Sep 23, 2024

View reviewed changes

Name Throwables in MonadCancel

b0da792

mr-git reviewed Sep 23, 2024

View reviewed changes

skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala Outdated Show resolved Hide resolved

Docs for latencyBuckets

26422a3

mr-git reviewed Sep 23, 2024

View reviewed changes

skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala Show resolved Hide resolved

mr-git reviewed Sep 23, 2024

View reviewed changes

skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala Show resolved Hide resolved

mr-git reviewed Sep 23, 2024

View reviewed changes

skafka/src/main/scala/com/evolutiongaming/skafka/producer/ProducerMetrics.scala Outdated Show resolved Hide resolved

vilunov and others added 2 commits September 23, 2024 15:00

Apply suggestions from code review

ea64058

Co-authored-by: Mareks Rampāns <[email protected]>

Update skafka/src/main/scala/com/evolutiongaming/skafka/consumer/Cons…

ac12622

…umerMetrics.scala Co-authored-by: Mareks Rampāns <[email protected]>

mr-git reviewed Sep 24, 2024

View reviewed changes

skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala Outdated Show resolved Hide resolved

changed name

0c2fd0f

mr-git approved these changes Sep 24, 2024

View reviewed changes

fix scala 3

97c1386

mr-git reviewed Sep 24, 2024

View reviewed changes

skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala Outdated Show resolved Hide resolved

mr-git reviewed Sep 24, 2024

View reviewed changes

skafka/src/main/scala/com/evolutiongaming/skafka/producer/ProducerMetrics.scala Outdated Show resolved Hide resolved

vilunov and others added 3 commits September 24, 2024 15:09

Apply suggestions from code review

263854d

Co-authored-by: Mareks Rampāns <[email protected]>

bump minor version

fece4c1

Merge branch 'master' into nviliunov/histograms

4f67a76

dfakhritdinov merged commit 0b37012 into evolution-gaming:master Sep 25, 2024
3 of 4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add histogram-based metrics #440

Add histogram-based metrics #440

vilunov commented Sep 23, 2024

Phill101 left a comment

mr-git commented Sep 23, 2024

mr-git commented Sep 23, 2024

mr-git commented Sep 23, 2024

coveralls commented Sep 24, 2024 •

edited

Loading

Add histogram-based metrics #440

Add histogram-based metrics #440

Conversation

vilunov commented Sep 23, 2024

Phill101 left a comment

Choose a reason for hiding this comment

mr-git commented Sep 23, 2024

mr-git commented Sep 23, 2024

mr-git commented Sep 23, 2024

coveralls commented Sep 24, 2024 • edited Loading

Pull Request Test Coverage Report for Build 11029572465

Details

💛 - Coveralls

coveralls commented Sep 24, 2024 •

edited

Loading