Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

tx receipt don't contains events #580

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Sep 22, 2021

Closes: #575

Description

  • convert tx hash when query tx logs
  • transaction index in tx logs should start from 0

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

- Should convert tx hash when query transaction logs
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #580 (16124b2) into main (d84837a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #580   +/-   ##
=======================================
  Coverage   52.53%   52.54%           
=======================================
  Files          64       64           
  Lines        5276     5277    +1     
=======================================
+ Hits         2772     2773    +1     
  Misses       2350     2350           
  Partials      154      154           
Impacted Files Coverage Δ
x/evm/keeper/state_transition.go 68.18% <100.00%> (+0.11%) ⬆️

@yihuang
Copy link
Contributor Author

yihuang commented Sep 22, 2021

Not sure how to test the RPC API, but it's verified in the integration test of Cronos: crypto-org-chain/cronos#93

Copy link
Contributor

@leejw51crypto leejw51crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze fedekunze merged commit 01b789c into evmos:main Sep 22, 2021
@yihuang yihuang deleted the remove-tx-logs branch September 22, 2021 09:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_getTransactionReceipt does not return events in logs[]
3 participants