Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

No test on the transaction receipt api #582

Closed
yihuang opened this issue Sep 22, 2021 · 2 comments · Fixed by #678
Closed

No test on the transaction receipt api #582

yihuang opened this issue Sep 22, 2021 · 2 comments · Fixed by #678
Assignees
@yihuang

Comments

@yihuang
Copy link
Contributor

yihuang commented Sep 22, 2021

#580

To prevent similar issues don't happen again.
@yihuang yihuang self-assigned this Sep 22, 2021
@yihuang
Copy link
Contributor Author

yihuang commented Sep 29, 2021

@fedekunze I tried to add RPC test for the receipt API, but then I found that lots of RPC test cases fail, is that expected right now?

@JayT106
Copy link
Contributor

JayT106 commented Oct 7, 2021

@fedekunze I tried to add RPC test for the receipt API, but then I found that lots of RPC test cases fail, is that expected right now?

#608 has been merged
I think you can proceed with your test.

@yihuang yihuang mentioned this issue Oct 15, 2021
Merged
11 tasks
yihuang added a commit to yihuang/ethermint that referenced this issue Oct 19, 2021
@yihuang
Problem: No test on the transaction receipt api
6c29063 
Closes: evmos#582

- add receipt rpc test for erc20 transfer logs
fedekunze pushed a commit that referenced this issue Oct 20, 2021
@yihuang
rpc: transaction receipt test (#678)
1000461 
* Problem: No test on the transaction receipt api

Closes: #582

- add receipt rpc test for erc20 transfer logs

* lower gas fee

* build with go 1.17 in CI

* use go 1.17 in test-solidity

* fix merge
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yihuang yihuang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Problem: No test on the transaction receipt api yihuang/ethermint
2 participants
@yihuang @JayT106