Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix a typo in context parameter #329

Merged
merged 2 commits into from
Jul 21, 2021
Merged

fix a typo in context parameter #329

merged 2 commits into from
Jul 21, 2021

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Jul 21, 2021

The previous code is not incorrect since the method SetBlockBloom use the ctx passed in rather than the k.ctx.
It's confusing that sometimes methods use ctx in parameter, sometimes use k.ctx, but that's another issue.

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

The previous code is not incorrect since the method `SetBlockBloom` use the `ctx` passed in rather than the `k.ctx`.
It's confusing that sometimes methods use ctx in parameter, sometimes use `k.ctx`, but that's another issue.
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #329 (395c4e9) into main (0fa75ba) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   47.38%   47.38%           
=======================================
  Files          46       46           
  Lines        4611     4611           
=======================================
  Hits         2185     2185           
  Misses       2348     2348           
  Partials       78       78           
Impacted Files Coverage Δ
x/evm/keeper/abci.go 0.00% <0.00%> (ø)

@fedekunze fedekunze enabled auto-merge (squash) July 21, 2021 11:49
@fedekunze fedekunze merged commit d54663c into main Jul 21, 2021
@fedekunze fedekunze deleted the yihuang-patch-1 branch July 21, 2021 11:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants