evm: fix infinite context usage on EndBlock (#329)

The previous code is not incorrect since the method `SetBlockBloom` use the `ctx` passed in rather than the `k.ctx`. It's confusing that sometimes methods use ctx in parameter, sometimes use `k.ctx`, but that's another issue. Co-authored-by: Federico Kunze Küllmer <[email protected]>
evmos · Jul 21, 2021 · d54663c · d54663c
1 parent 0fa75ba
commit d54663c
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/x/evm/keeper/abci.go b/x/evm/keeper/abci.go
@@ -29,7 +29,7 @@ func (k *Keeper) EndBlock(ctx sdk.Context, req abci.RequestEndBlock) []abci.Vali
 
 	// Gas costs are handled within msg handler so costs should be ignored
 	infCtx := ctx.WithGasMeter(sdk.NewInfiniteGasMeter())
-	k.WithContext(ctx)
+	k.WithContext(infCtx)
 
 	k.SetBlockBloom(infCtx, req.Height, ethtypes.BytesToBloom(k.GetBlockBloomTransient().Bytes()))
 	k.WithContext(ctx)