This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 566
fix!: london hardfork check logic in json-rpc apis #1068
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
fedekunze,
khoslaventures and
jolube
as code owners
April 29, 2022 03:00
Closes: evmos#1067 Solution: - Add `BaseFee` grpc query handler in evm module which also checks the current london hardfork status.
Codecov Report
@@ Coverage Diff @@
## main #1068 +/- ##
==========================================
+ Coverage 60.79% 60.87% +0.07%
==========================================
Files 80 80
Lines 6670 6683 +13
==========================================
+ Hits 4055 4068 +13
Misses 2404 2404
Partials 211 211
|
yihuang
changed the title
fix london hardfork check logic in json-rpc apis
fix!: london hardfork check logic in json-rpc apis
Apr 29, 2022
13 tasks
fedekunze
reviewed
Apr 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comments.
Can you also add the new query to the spec and CLI? Should we remove the fee market gRPC base fee query?
fedekunze
approved these changes
Apr 30, 2022
yihuang
commented
Apr 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1067
Solution:
BaseFee
grpc query handler in evm module which also checks the current london hardfork status.the
eth_getBlockByNumber
rpc api is tested in cronos's related PR: https://github.com/crypto-org-chain/cronos/pull/446/files#diff-ece6d4f65047a3ec6f2294c4e4fc1eecf8a2b44928f478867399e69f194fc1beR128For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)