-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: query legacy block failed after upgrade #446
Conversation
Solution: - fix in ethermint and update the dependency
Codecov Report
@@ Coverage Diff @@
## main #446 +/- ##
===========================================
+ Coverage 21.51% 39.40% +17.88%
===========================================
Files 27 31 +4
Lines 1729 1571 -158
===========================================
+ Hits 372 619 +247
+ Misses 1324 906 -418
- Partials 33 46 +13
|
@@ -160,7 +160,7 @@ replace ( | |||
|
|||
github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 | |||
|
|||
github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.10.0-alpha1-cronos-8.0.20220426081631-a178ce6dba6e | |||
github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.10.0-alpha1-cronos-8.0.20220430162531-36b9c095b351 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is there a need for the ethermint fork? can the upstream be used if the PRs are merged?
there's still breaking changes are not included for 0.7.0 upgrade, including the ibc-go 0.3, so we'll need to maintain this fork for the 0.7.0 release. |
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)