-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pydantic version #942
Bump pydantic version #942
Conversation
src/evidently/_version.py
Outdated
@@ -1,5 +1,5 @@ | |||
#!/usr/bin/env python | |||
# coding: utf-8 | |||
|
|||
version_info = (0, 4, 13) | |||
version_info = (0, 4, 14) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's undo these changes. we bump the version ourselves
@maciejmajerczyk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
9f6dc4c
to
094c018
Compare
Hi @maciejmajerczyk! Thanks for your contribution! As you can see, there is a failed test To reproduce the error you should run evidently ui --port 8000 --demo-projects all Next go to http://localhost:8000 and see logs in terminal |
fastapi/fastapi#10360 - I guess fastapi still doesn't work with pydantic.v1 models :( |
Hi @maciejmajerczyk , We discussed the issue with the pydantic version. Indeed this should be addressed immediately and here is an option we could suggest now: as evidently ui service depends of FastAPI we cannot bump pydantic version right now (fastapi/fastapi#10360). However, if you use evidently to generate Reports or TestSuites only (without running We certainly understand that this solution is neither convenient nor stable. This is why we now replace FastAPI with litestar. After this replacement we will be able to bump pydantic version. I believe it will happen in a couple of weeks. |
Issue: #862
Notes:
upgraded pydantic version to allow versions <3
fixed tests in test_pydantic_utils.py yo use _pydantic_compat.py
increased evidently version so we get a new version