-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pydantic and pyarrow version #862
Comments
@Atharva-Phatak Also in case this helps others - since the CVE affects all PyArrow versions from 0.14.0 to 14.0.0 pip install pyarrow_hotfix It probably makes sense to release a pyarrow bump and version upgrade separately as Pyarrow upgrade will probably give more returns in terms of performance - and address the open security CVE. On Pydantic - Just one note pydantic and fastapi are interdependent - with some complexities
thank you and regards |
Not having Pydantic v2 seems to impact a lot of packages including fastapi, AutoGluon and anything using lightning, space, thinc or weasel. Any idea when this might be addressed? I wish I could help, but that's way above my pay grade. ;-) |
We removed pyarrow dependency in #885 and replaced it with pandas[parquet] - which means you can use any pyarrow version pandas is comfortable with. |
Hoping to get some guidance on how I can use evidently with pydantic v2. The
|
I added PR #942 with fixing of that issue. It's kinda blocker for us as we use pydantic>2 across projects |
Hi there! As evidently ui service depends of FastAPI and FastAPI does not work with pydantic 2 installed fastapi/fastapi#10360 we cannot bump pydantic version right now. However we see that pydantic 2 is very much needed. This is why we now replace FastAPI with litestar. After this replacement we will be able to bump pydantic version, as litestar has no issues with that. I believe it will be finished during the next couple of weeks. However, if you use evidently to generate Reports or TestSuites without running I'm sorry it is taking us so long to fix this. |
Hi @emeli-dral, I am also running into this issue. Wondering if the timeline to get it fixed is still the same or if there's any developments? Thanks for the hard work! |
Hi @eduardo-lourenco, |
Hey, just ran into this issue. FastAPI shouldn't have any issues with pydantic-v2 - according this issue. Note that that issue is older than the one being discussed here. At $WORK we're happily using both FastAPI with pydantic-v2. So I don't see the need for you folks to replace FastAPI with something else at all. In your requirements.dev you seem to have some sort of limitation on the FastAPI version - I'd recommend changing that. It also feels bizarre for a If PRs are welcome I'd be happy to contribute - some poor soul will have to spend a few hours tweaking the dependencies but this shouldn't be too hard. |
Hi @JoaquimEsteves , The issue is a bit more nuanced than just compatibility between Pydantic v2 and FastAPI - it is the inability to enforce a specific Pydantic model version when using FastAPI with Pydantic v2. To sum up:
As a result, we decided to replace the FastAPI dependency for litestar. On top of this, we experienced some other issues with FastAPI as we further develop the UI and collector service (where it is used). So we expect additional performance improvements by migrating to Litestar - solving two issues at once. You can see that this PR is already in the final stages: #995. It was just merged and I expect to release it very soon. Hopefully today🤞 As mentioned, in the meantime, if you only work with Evidently Reports / Test Suites (without self-hosting the UI), you can use a workaround by first installing Evidently and then installing Pydantic 2 after it in the same environment. And if you see something worth contributing on - feel free to send the PR / open a separate issue, you are very welcome to contribute! |
Hey @JoaquimEsteves , @dylangreenleaf , @blueoceancruiser , @maciejmajerczyk , @eduardo-lourenco ! I'm sorry it took us so long! Please feel free to give it a try and let us know if you encounter any more problems with pydantic (or anything else)😊 |
I was trying to install evidently with the latest versions of pydantic (v2) and pyarrow. I found we are still using version 11dev of pyarrow and currently pyarrow is on version 14. I think we can bump up both the dependencies and see massive perfomance gains.
The text was updated successfully, but these errors were encountered: