Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tidy-html5 to validate the home page #15594

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

octopusinvitro
Copy link
Contributor

@octopusinvitro octopusinvitro commented Nov 18, 2016

What does this do?

HTML-validates the home page

Why was this needed?

HTML was broken

Relevant Issue(s)

Closes #15562
Closes #15452

Implementation notes

The attributes removed to make the validation pass where added back with JavaScript.

Screenshots

placeholder

Notes to Reviewer

Errors corrected:

  • Attribute "placeholder" not allowed on element "select" at this point. At line 86, column 189
  • Attribute "autocorrect" not allowed on element "select" at this point. At line 86, column 189
  • Attribute "autocomplete" not allowed on element "select" at this point. At line 86, column 189

Notes to Merger

None

Errors corrected:
- Attribute "placeholder" not allowed on element "select" at this point. At line 86, column 189
- Attribute "autocorrect" not allowed on element "select" at this point. At line 86, column 189
- Attribute "autocomplete" not allowed on element "select" at this point. At line 86, column 189
@tmtmtmtm tmtmtmtm temporarily deployed to everypolitician-viewe-pr-15594 November 18, 2016 15:52 Inactive
@octopusinvitro octopusinvitro force-pushed the html-validate-home-page branch from 34800b8 to bbe7dc0 Compare November 18, 2016 15:56
@tmtmtmtm tmtmtmtm temporarily deployed to everypolitician-viewe-pr-15594 November 18, 2016 15:56 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants