Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the hint text visible again #15562

Open
octopusinvitro opened this issue Sep 21, 2016 · 0 comments
Open

Make the hint text visible again #15562

octopusinvitro opened this issue Sep 21, 2016 · 0 comments
Assignees
Labels

Comments

@octopusinvitro
Copy link
Contributor

Problem

After adding HTML validation to viewer-sinatra, some attributes had to be removed in order for the validation to pass. The “Search by country name” hint text now is missing from the search input on the homepage as a result of this.

Before:

screen shot 2016-09-20 at 17 24 35

After:

screen shot 2016-09-20 at 17 24 45

(Images by @zarino )

Proposed Solution

Since the text input (generated by selectToAutocomplete) uses copy-attributes-to-text-field to soak up whatever HTML attributes the source <select> element had. I guess, a satisfactory solution if we still want W3C compliant markup, would be to add the placeholder attribute back in with JavaScript, immediately before we call . selectToAutocomplete() in main.js.
-- Zarino.

Acceptance Criteria

The hint text is visible again in the search input on the homepage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant